Bug 2058364
| Summary: | Review Request: authbind - Allow non-root users to open restricted ports | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-12 19:44:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2022-02-24 18:10:01 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=83279604 Spec URL: https://dcavalca.fedorapeople.org/review/authbind/authbind.spec SRPM URL: https://dcavalca.fedorapeople.org/review/authbind/authbind-2.1.2-1.fc37.src.rpm Changelog: - fix description Note: this package installs a setuid binary helper, which rpmlint (rightfully) flags as bad. However, I don't think there's a way around it -- it's how this works in the first place. Also, I had to perform some pretty significant surgery on the Makefile in order to get it to build, including switching from calling the linker directly to using gcc (so LDFLAGS would be passed correctly) -- I'd appreciate a thorough review of authbind-makefile-fixes.patch. Thanks! Taking this review. Review notes: * Package is named appropriately * Package licensing is correctly indicated * Package builds and installs properly * Package generally follows guidelines I would advise reaching out to upstream to add a COPYING file for the license itself, since the path in debian/copyright doesn't exist on Fedora systems. Thanks! $ fedpkg request-repo authbind 2058364 https://pagure.io/releng/fedora-scm-requests/issue/45713 $ fedpkg request-branch --repo authbind f36 https://pagure.io/releng/fedora-scm-requests/issue/45714 $ fedpkg request-branch --repo authbind f35 https://pagure.io/releng/fedora-scm-requests/issue/45715 $ fedpkg request-branch --repo authbind epel8 https://pagure.io/releng/fedora-scm-requests/issue/45716 $ fedpkg request-branch --repo authbind epel9 https://pagure.io/releng/fedora-scm-requests/issue/45717 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/authbind FEDORA-2022-ce53f1ef2f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ce53f1ef2f FEDORA-2022-ce53f1ef2f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-8f22b16fe5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5 FEDORA-2022-bd477dea35 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35 FEDORA-EPEL-2022-1df65ad7ce has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce FEDORA-2022-8f22b16fe5 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8f22b16fe5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-bd477dea35 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-bd477dea35 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2022-1df65ad7ce has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2022-1df65ad7ce has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-8f22b16fe5 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-bd477dea35 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |