Bug 2058364 - Review Request: authbind - Allow non-root users to open restricted ports
Summary: Review Request: authbind - Allow non-root users to open restricted ports
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-24 18:10 UTC by Davide Cavalca
Modified: 2022-07-21 17:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-12 19:44:26 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-02-24 18:10:01 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/authbind/authbind.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/authbind/authbind-2.1.2-1.fc37.src.rpm

Description:
This package allows a package to be started as non-root but still bind to low
ports, without any changes to the application. 

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-02-24 18:10:03 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=83279604

Comment 3 Davide Cavalca 2022-02-24 18:13:47 UTC
Note: this package installs a setuid binary helper, which rpmlint (rightfully) flags as bad. However, I don't think there's a way around it -- it's how this works in the first place. Also, I had to perform some pretty significant surgery on the Makefile in order to get it to build, including switching from calling the linker directly to using gcc (so LDFLAGS would be passed correctly) -- I'd appreciate a thorough review of authbind-makefile-fixes.patch. Thanks!

Comment 4 Neal Gompa 2022-02-24 18:16:33 UTC
Taking this review.

Comment 5 Neal Gompa 2022-07-12 16:46:48 UTC
Review notes:

* Package is named appropriately
* Package licensing is correctly indicated
* Package builds and installs properly
* Package generally follows guidelines

I would advise reaching out to upstream to add a COPYING file for the license itself, since the path in debian/copyright doesn't exist on Fedora systems.

Comment 6 Davide Cavalca 2022-07-12 16:49:32 UTC
Thanks!

$ fedpkg request-repo authbind 2058364
https://pagure.io/releng/fedora-scm-requests/issue/45713
$ fedpkg request-branch --repo authbind f36
https://pagure.io/releng/fedora-scm-requests/issue/45714
$ fedpkg request-branch --repo authbind f35
https://pagure.io/releng/fedora-scm-requests/issue/45715
$ fedpkg request-branch --repo authbind epel8
https://pagure.io/releng/fedora-scm-requests/issue/45716
$ fedpkg request-branch --repo authbind epel9
https://pagure.io/releng/fedora-scm-requests/issue/45717

Comment 7 Gwyn Ciesla 2022-07-12 18:04:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/authbind

Comment 8 Fedora Update System 2022-07-12 19:41:34 UTC
FEDORA-2022-ce53f1ef2f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ce53f1ef2f

Comment 9 Fedora Update System 2022-07-12 19:44:26 UTC
FEDORA-2022-ce53f1ef2f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-07-12 20:09:34 UTC
FEDORA-2022-8f22b16fe5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5

Comment 11 Fedora Update System 2022-07-12 20:18:31 UTC
FEDORA-2022-bd477dea35 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35

Comment 12 Fedora Update System 2022-07-12 20:46:06 UTC
FEDORA-EPEL-2022-1df65ad7ce has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce

Comment 13 Fedora Update System 2022-07-13 01:28:58 UTC
FEDORA-2022-8f22b16fe5 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8f22b16fe5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-07-13 01:34:21 UTC
FEDORA-2022-bd477dea35 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-bd477dea35 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-07-13 01:43:20 UTC
FEDORA-EPEL-2022-1df65ad7ce has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-07-21 01:03:28 UTC
FEDORA-EPEL-2022-1df65ad7ce has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2022-07-21 16:39:35 UTC
FEDORA-2022-8f22b16fe5 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-07-21 17:10:10 UTC
FEDORA-2022-bd477dea35 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.