Bug 2060710
| Summary: | Review Request: golang-github-bep-goat - C bindings and an API for generating diagrams from ASCII art | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Fabio Alessandro Locati <me> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | me, package-review |
| Target Milestone: | --- | Flags: | me:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-13 17:25:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1930952 | ||
|
Description
W. Michael Petullo
2022-03-04 03:23:57 UTC
Trying to build this from SPEC against F37, I receive: canvas_test.go:7:2: cannot find package "github.com/frankban/quicktest" in any of: /usr/lib/golang/src/github.com/frankban/quicktest (from $GOROOT) /builddir/build/BUILD/goat-0.5.0/_build/src/github.com/frankban/quicktest (from $GOPATH) /usr/share/gocode/src/github.com/frankban/quicktest I do not see the `%go_generate_buildrequires` nor explicit dependencies. If rebuilt with go2rpm 1.6.0, I think it will self-fix I rebuilt using go2rpm 1.6.1. Nice job! go2rpm package, fedora-review is correct: - The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks! Thank you, Fabio! Requested Git module: https://pagure.io/releng/fedora-scm-requests/issue/43649. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-goat FEDORA-2022-175463cc01 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-175463cc01 FEDORA-2022-175463cc01 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-4a6ff273cf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf FEDORA-2022-e340b00ea4 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4 FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4a6ff273cf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e340b00ea4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |