Bug 2060710 - Review Request: golang-github-bep-goat - C bindings and an API for generating diagrams from ASCII art
Summary: Review Request: golang-github-bep-goat - C bindings and an API for generating...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1930952
TreeView+ depends on / blocked
 
Reported: 2022-03-04 03:23 UTC by W. Michael Petullo
Modified: 2022-05-07 04:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-13 17:25:55 UTC
Type: ---
Embargoed:
me: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2022-03-04 03:23:57 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-goat.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-goat-0.5.0-1.fc35.src.rpm
Description: C bindings and an API for generating diagrams from ASCII art.
Fedora Account System Username: mikep

Comment 1 Fabio Alessandro Locati 2022-04-10 16:38:35 UTC
Trying to build this from SPEC against F37, I receive:

canvas_test.go:7:2: cannot find package "github.com/frankban/quicktest" in any of:
	/usr/lib/golang/src/github.com/frankban/quicktest (from $GOROOT)
	/builddir/build/BUILD/goat-0.5.0/_build/src/github.com/frankban/quicktest (from $GOPATH)
	/usr/share/gocode/src/github.com/frankban/quicktest

I do not see the `%go_generate_buildrequires` nor explicit dependencies.

If rebuilt with go2rpm 1.6.0, I think it will self-fix

Comment 2 W. Michael Petullo 2022-04-12 20:38:21 UTC
I rebuilt using go2rpm 1.6.1.

Comment 3 Fabio Alessandro Locati 2022-04-13 07:34:40 UTC
Nice job!

Comment 4 Fabio Alessandro Locati 2022-04-13 07:36:16 UTC
go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

Comment 5 W. Michael Petullo 2022-04-13 16:27:18 UTC
Thank you, Fabio! Requested Git module: https://pagure.io/releng/fedora-scm-requests/issue/43649.

Comment 6 Gwyn Ciesla 2022-04-13 16:45:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-goat

Comment 7 Fedora Update System 2022-04-13 17:25:11 UTC
FEDORA-2022-175463cc01 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-175463cc01

Comment 8 Fedora Update System 2022-04-13 17:25:55 UTC
FEDORA-2022-175463cc01 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-04-13 20:10:06 UTC
FEDORA-2022-4a6ff273cf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf

Comment 10 Fedora Update System 2022-04-13 20:14:08 UTC
FEDORA-2022-e340b00ea4 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4

Comment 11 Fedora Update System 2022-04-14 16:40:39 UTC
FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4a6ff273cf \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4a6ff273cf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-14 18:49:06 UTC
FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e340b00ea4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e340b00ea4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-04-21 21:21:38 UTC
FEDORA-2022-4a6ff273cf has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-05-07 04:24:03 UTC
FEDORA-2022-e340b00ea4 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.