Bug 2061496

Summary:	etcd RecentBackup=Unknown ControllerStarted contains no message string
Product:	OpenShift Container Platform	Reporter:	W. Trevor King <wking>
Component:	Etcd	Assignee:	Allen Ray <alray>
Status:	CLOSED ERRATA	QA Contact:	ge liu <geliu>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.8	CC:	alray, aos-bugs, aos-team-ota, jiajliu, mifiedle, omichael, travi, wking
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	2061444	Environment:
Last Closed:	2022-08-10 10:52:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description W. Trevor King 2022-03-07 16:58:20 UTC

+++ This bug was initially created as a clone of Bug #2061444 +++

Description of problem:  Using channel candidate-4.10 and upgrading without force, CVO reports that the upgrade is unsafe for about 4 minutes before proceeding:

...
    - lastTransitionTime: "2022-03-07T15:20:31Z"                                                    
      message: 'Precondition "EtcdRecentBackup" failed because of "ControllerStarted": '
      reason: UpgradePreconditionCheckFailed                                                       
      status: "True"                                                                               
      type: Failing
...

---

etcd is not setting a 'message' with ControllerStarted in [1], which makes it hard for folks to figure out what that message means.  It should probably say something like:

  hey, we see we're about to make a minor bump, and will be taking an etcd snapshot shortly

but more formally, or make some other statement that describes what's going on with that condition.

[1]: https://github.com/openshift/cluster-etcd-operator/blob/e9c303d825f12e133f87deab5edc4b98161b6bc7/pkg/operator/upgradebackupcontroller/upgradebackupcontroller.go#L104-L114

Comment 2 W. Trevor King 2022-05-05 23:56:56 UTC

Message strings are for human consumption, and if no external humans are complaining, I don't think we need to actively backport this one.  I'm also not opposed to backports if they apply cleanly and folks want to do that.  Either way.

Comment 7 errata-xmlrpc 2022-08-10 10:52:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069