Bug 2061496 - etcd RecentBackup=Unknown ControllerStarted contains no message string
Summary: etcd RecentBackup=Unknown ControllerStarted contains no message string
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Etcd
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: Allen Ray
QA Contact: ge liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-07 16:58 UTC by W. Trevor King
Modified: 2022-08-10 10:53 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 2061444
Environment:
Last Closed: 2022-08-10 10:52:44 UTC
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-etcd-operator pull 760 0 None open Bug 2061496: Adding message to ControllerStarted:RecentBackup condition 2022-03-07 17:45:41 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:53:04 UTC

Description W. Trevor King 2022-03-07 16:58:20 UTC 
+++ This bug was initially created as a clone of Bug #2061444 +++

Description of problem:  Using channel candidate-4.10 and upgrading without force, CVO reports that the upgrade is unsafe for about 4 minutes before proceeding:

...
    - lastTransitionTime: "2022-03-07T15:20:31Z"                                                    
      message: 'Precondition "EtcdRecentBackup" failed because of "ControllerStarted": '
      reason: UpgradePreconditionCheckFailed                                                       
      status: "True"                                                                               
      type: Failing
...

---

etcd is not setting a 'message' with ControllerStarted in [1], which makes it hard for folks to figure out what that message means.  It should probably say something like:

  hey, we see we're about to make a minor bump, and will be taking an etcd snapshot shortly

but more formally, or make some other statement that describes what's going on with that condition.

[1]: https://github.com/openshift/cluster-etcd-operator/blob/e9c303d825f12e133f87deab5edc4b98161b6bc7/pkg/operator/upgradebackupcontroller/upgradebackupcontroller.go#L104-L114
Comment 2 W. Trevor King 2022-05-05 23:56:56 UTC 
Message strings are for human consumption, and if no external humans are complaining, I don't think we need to actively backport this one.  I'm also not opposed to backports if they apply cleanly and folks want to do that.  Either way.
Comment 7 errata-xmlrpc 2022-08-10 10:52:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069
Note You need to log in before you can comment on or make changes to this bug.