Bug 2062960
| Summary: | Review Request: plasma-mobile-sounds - Plasma Mobile Sound Theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Justin Zobel <justin.zobel> |
| Component: | Package Review | Assignee: | Onuralp Sezer <thunderbirdtr> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, thunderbirdtr |
| Target Milestone: | --- | Flags: | thunderbirdtr:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-11 01:19:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Justin Zobel
2022-03-11 02:07:59 UTC
https://invent.kde.org/plasma-mobile/plasma-mobile-sounds/-/tree/master/ I can see that it is just generating oga files from wav files. First try to do that with ffmpeg-free If not we may just copy music files and not using "cmake" at all. Technically If only copying music files, we don't need Qt dependencies. Cmake file just copying to proper location that is all. So for that reason we may want to add "noarch" as well. It works without the extra-cmake-modules and Qt5 build dependency, so I've removed those but I don't see the point in not using CMake as they've already done the work for us with all the build steps. I think keeping our spec as simple as possible and letting upstream take care of the build instructions is the best approach. Happy to hear feedback though. Rebuilt, spec and srpm URL remain the same. Also let's make this one "noarch" as well. Because we not compiling anything. typo : s/we no/we are not* Done. Approved. Repo and branches requested: https://pagure.io/releng/fedora-scm-requests/issue/44072 https://pagure.io/releng/fedora-scm-requests/issue/44073 https://pagure.io/releng/fedora-scm-requests/issue/44074 https://pagure.io/releng/fedora-scm-requests/issue/44075 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-mobile-sounds FEDORA-2022-3dc1ca642c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3dc1ca642c FEDORA-2022-3dc1ca642c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-3dc1ca642c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3dc1ca642c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-e2a36611b6 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e2a36611b6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e2a36611b6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-3dc1ca642c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-e2a36611b6 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |