Bug 2062960 - Review Request: plasma-mobile-sounds - Plasma Mobile Sound Theme
Summary: Review Request: plasma-mobile-sounds - Plasma Mobile Sound Theme
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Onuralp Sezer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-11 02:07 UTC by Justin Zobel
Modified: 2022-05-11 01:25 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-11 01:19:21 UTC
Type: Bug
Embargoed:
thunderbirdtr: fedora-review+


Attachments (Terms of Use)

Comment 1 Onuralp Sezer 2022-04-27 06:20:11 UTC
https://invent.kde.org/plasma-mobile/plasma-mobile-sounds/-/tree/master/


I can see that it is just generating oga files from wav files. First try to do that with ffmpeg-free If not we may just copy music files and not using "cmake" at all. Technically If only copying music files, we don't need Qt dependencies. Cmake file just copying to proper location that is all. So for that reason we may want to add "noarch" as well.

Comment 2 Justin Zobel 2022-04-27 07:09:39 UTC
It works without the extra-cmake-modules and Qt5 build dependency, so I've removed those but I don't see the point in not using CMake as they've already done the work for us with all the build steps. I think keeping our spec as simple as possible and letting upstream take care of the build instructions is the best approach. Happy to hear feedback though.

Rebuilt, spec and srpm URL remain the same.

Comment 3 Onuralp Sezer 2022-04-27 07:53:20 UTC
Also let's make this one "noarch" as well. Because we not compiling anything.

Comment 4 Onuralp Sezer 2022-04-27 07:53:55 UTC
typo : s/we no/we are not*

Comment 5 Justin Zobel 2022-04-27 08:59:11 UTC
Done.

Comment 6 Onuralp Sezer 2022-04-29 12:48:10 UTC
Approved.

Comment 8 Gwyn Ciesla 2022-05-02 15:00:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-mobile-sounds

Comment 9 Fedora Update System 2022-05-03 02:44:06 UTC
FEDORA-2022-3dc1ca642c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3dc1ca642c

Comment 10 Fedora Update System 2022-05-03 13:33:14 UTC
FEDORA-2022-3dc1ca642c has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-3dc1ca642c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3dc1ca642c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-05-03 15:28:38 UTC
FEDORA-2022-e2a36611b6 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-e2a36611b6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e2a36611b6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-05-11 01:19:21 UTC
FEDORA-2022-3dc1ca642c has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-05-11 01:25:25 UTC
FEDORA-2022-e2a36611b6 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.