Bug 2064804

Summary: Oddly packaged systemd cryptsetup plugins
Product: [Fedora] Fedora Reporter: Ondrej Kozina <okozina>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: evan, extras-qa, fedoraproject, filbranden, flepied, gmazyland, lnykryn, msekleta, ryncsn, ssahani, s, systemd-maint, yuwatana, zbyszek
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-250.3-8.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2031873 Environment:
Last Closed: 2022-03-24 00:56:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2031873, 2074833    
Bug Blocks:    

Description Ondrej Kozina 2022-03-16 15:27:01 UTC
+++ This bug was initially created as a clone of Bug #2031873 +++

Description of problem:

Seems that systemd cryptsetup plugins are oddly packaged in systemd-devel sub-package (therefore not installed usually). Not sure what final destination should be, but I have used attached patch to create systemd-cryptsetup-plugins subpackage when I was devel/testing it.

There should probably be some dependencies so that systemd-cryptsetup and systemd-cryptenroll pull the plugins in.

Version-Release number of selected component (if applicable):
systemd-250~rc1-2.fc36

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2021-12-13 20:26:17 UTC ---

Hmm, why create a separate subpackage? I'd just put those files in systemd-udev.
Or in other words, when would you install systemd-cryptsetup-plugins but not system-udev?

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2021-12-14 18:09:25 UTC ---

I moved those plugins to -udev for now.

--- Additional comment from Ondrej Kozina on 2021-12-14 19:15:31 UTC ---

Ok, thanks! It seems to work just fine.

--- Additional comment from Evan Anderson on 2022-03-13 19:26:17 UTC ---

This appears to be broken again on F36. The systemd-devel package is back to providing libcryptsetup-token-system-* libraries. https://koji.fedoraproject.org/koji/rpminfo?rpmID=29600259

--- Additional comment from Evan Anderson on 2022-03-13 23:18:50 UTC ---

The issue stems from how the devel regex in split-files.py treats .so files. It assumes that any .so file in a lib directory, with the exception of libsystemd-shared-*.so, are development libraries. The newly added libcryptsetup-token* shared libraries break this assumption. The regex needs to be updated to ignore the cryptsetup libs since those will be picked up later by the matching rule for -udev. I've attached a patch that makes this correction.

--- Additional comment from Milan Broz on 2022-03-14 07:10:06 UTC ---

(In reply to Evan Anderson from comment #5)
> Created attachment 1865807 [details]
> Fix regex for -devel

Can you please reopen the bug then or create a new one? That patch is not in systemd build yet.

--- Additional comment from Ondrej Kozina on 2022-03-16 15:26:09 UTC ---

I can confirm it reappears in systemd-devel package.

Comment 1 Fedora Update System 2022-03-17 22:09:47 UTC
FEDORA-2022-1dd97eaa2b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1dd97eaa2b

Comment 2 Fedora Update System 2022-03-18 15:53:29 UTC
FEDORA-2022-1dd97eaa2b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-1dd97eaa2b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1dd97eaa2b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2022-03-24 00:56:38 UTC
FEDORA-2022-1dd97eaa2b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.