Bug 2065836

Summary:	controller_config.yml.j2 merge type should be set to merge (currently using the default strategic)
Product:	Migration Toolkit for Containers	Reporter:	Jason Montleon <jmontleo>
Component:	Operator	Assignee:	Jason Montleon <jmontleo>
Status:	CLOSED ERRATA	QA Contact:	Prasad Joshi <prajoshi>
Severity:	unspecified	Docs Contact:	Richard Hoch <rhoch>
Priority:	unspecified
Version:	1.6.3	CC:	ernelson, prajoshi, rjohnson
Target Milestone:	---
Target Release:	1.6.4
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/konveyor/mig-operator/pull/802
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2065837 (view as bug list)		Environment:
Last Closed:	2022-04-19 08:08:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2065837

Description Jason Montleon 2022-03-18 20:19:15 UTC

Description of problem:
When the controller config is created or updated it is done via strategic merge. 

The downside to this is that if options are removed the parameters will not be removed from the config

Version-Release number of selected component (if applicable):
1.7.0, 1.6.3, and 1.5.3

How reproducible:
Always

Steps to Reproduce:
1. Set an extra rsync option in the MigrationController CR
2. Remove it
3. Note that it is not removed from the controller config

Actual results:
Removed options aren't removed from the config

Expected results:
Removed options should be removed from the config

Additional info:
We should set type=merge when creating the cluster config in the operator.

Comment 1 Jason Montleon 2022-03-21 13:36:45 UTC

https://github.com/konveyor/mig-operator/pull/802

Comment 10 errata-xmlrpc 2022-04-19 08:08:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) 1.6.4 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1393