Bug 2065836 - controller_config.yml.j2 merge type should be set to merge (currently using the default strategic)
Summary: controller_config.yml.j2 merge type should be set to merge (currently using t...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Containers
Classification: Red Hat
Component: Operator
Version: 1.6.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.6.4
Assignee: Jason Montleon
QA Contact: Prasad Joshi
Richard Hoch
URL: https://github.com/konveyor/mig-opera...
Whiteboard:
Depends On:
Blocks: 2065837
TreeView+ depends on / blocked
 
Reported: 2022-03-18 20:19 UTC by Jason Montleon
Modified: 2022-04-19 08:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2065837 (view as bug list)
Environment:
Last Closed: 2022-04-19 08:08:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2022:1393 0 None None None 2022-04-19 08:08:17 UTC

Description Jason Montleon 2022-03-18 20:19:15 UTC
Description of problem:
When the controller config is created or updated it is done via strategic merge. 

The downside to this is that if options are removed the parameters will not be removed from the config

Version-Release number of selected component (if applicable):
1.7.0, 1.6.3, and 1.5.3

How reproducible:
Always

Steps to Reproduce:
1. Set an extra rsync option in the MigrationController CR
2. Remove it
3. Note that it is not removed from the controller config

Actual results:
Removed options aren't removed from the config

Expected results:
Removed options should be removed from the config

Additional info:
We should set type=merge when creating the cluster config in the operator.

Comment 1 Jason Montleon 2022-03-21 13:36:45 UTC
https://github.com/konveyor/mig-operator/pull/802

Comment 10 errata-xmlrpc 2022-04-19 08:08:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) 1.6.4 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1393


Note You need to log in before you can comment on or make changes to this bug.