Bug 2065878

First please change URL section into "https://invent.kde.org/plasma/plasma-mobile"

Done.

New URLs:

SPEC: https://pagure.io/plasma-mobile_rpm/raw/master/f/plasma-mobile.spec
SRPM: https://pagure.io/plasma-mobile_rpm/raw/master/f/plasma-mobile-5.24.3-1.fc36.src.rpm

- I don't know if the License line is correct
- Several lines are not properly aligned
- %{_kf5_datadir}/kservices5 (and others) should not be owned here. Maybe better something like: %{_kf5_datadir}/kservices5/*

Licenses are from: https://invent.kde.org/plasma/plasma-mobile/-/tree/master/LICENSES
Many directories in %files fixed up and made clean

Not sure about line alignment, is it needed? Which need aligning?

- Licenses look good, thanks for that.
- Alignment looks good, not sure what that is about.
- I think you were too aggressive with taking out directories, there are now three directories not owned by anything else.
%dir %{_kf5_datadir}/plasma/quicksettings
%dir %{_kf5_qmldir}/org/kde/plasma/mm
%dir %{_kf5_qmldir}/org/kde/plasma/quicksetting


Runtime depends on plasma-nano ( https://bugzilla.redhat.com/show_bug.cgi?id=2043940 ) but I think we can get them both built in parallel, so I'm not too concerned about that, just pointing it out.

Should be all good now thanks Troy!

New URLs:

SPEC: https://pagure.io/plasma-mobile_rpm/raw/master/f/plasma-mobile.spec
SRPM: https://pagure.io/plasma-mobile_rpm/raw/master/f/plasma-mobile-5.25.4-1.fc36.src.rpm

With the update to 5.25.4, now it doesn't build.
You need to at least add

BuildRequires: cmake(libkworkspace)
BuildRequires: cmake(Qt5Svg)

But then it fails looking for "PW::KWorkspace" which I cannot find.
I'm sorry.  It's so close.

All good Troy, thanks for the review. I've added the requested dependencies and tested in mock, it built for me now.

It does complain about PW::KWorkspace missing but it isn't a required package from what I understand from reading the CMakeLists.txt file.

This looks great.  Thank you for your patience.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- MANUAL NOTE: Package uses a name that already exists.
  This is known and expected.  plasma-mobile was retired
  a few years ago and this review is to revive the package.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     MANUAL: .so files are not in ld path
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Creative Commons CC0 1.0", "*No copyright* GNU
     General Public License, Version 2", "Unknown or generated", "Creative
     Commons CC0 1.0", "GNU General Public License, Version 2", "GNU
     Library General Public License, Version 2.0", "GNU Lesser General
     Public License, Version 2.1", "GNU Lesser General Public License,
     Version 3", "*No copyright* GNU General Public License, Version 3",
     "*No copyright* GNU Lesser General Public License, Version 3", "*No
     copyright* MIT License", "*No copyright* GNU Library General Public
     License, Version 2.0", "*No copyright* GNU Lesser General Public
     License, Version 2.1". 29 files have unknown license. Detailed output
     of licensecheck in /home/quake/review/2065878-plasma-
     mobile/licensecheck.txt
     MANUAL: Verified that all the files are in the Licenses files.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/qt5/qml/org/kde/plasma/mm
[x]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/lib64/qt5/qml/org/kde/plasma/mm
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1054720 bytes in /usr/share
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 3.1 starting (python version = 3.11.0, NVR = mock-3.1-1.fc37)...
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish: chroot init
INFO: installing package(s): /builddir/plasma-mobile-debugsource-5.25.4-1.fc38.x86_64.rpm /builddir/plasma-mobile-debuginfo-5.25.4-1.fc38.x86_64.rpm /builddir/plasma-mobile-5.25.4-1.fc38.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 8b999b1332614d9cac9cd177f2326a21 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.7_5e4ipx:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$  --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 38 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/plasma-mobile-debugsource-5.25.4-1.fc38.x86_64.rpm /builddir/plasma-mobile-debuginfo-5.25.4-1.fc38.x86_64.rpm /builddir/plasma-mobile-5.25.4-1.fc38.x86_64.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
plasma-mobile: /usr/lib64/qt5/plugins/kcms/kcm_mobileshell.so
plasma-mobile: /usr/lib64/qt5/plugins/plasma/applets/plasma_applet_phonepanel.so
plasma-mobile: /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_homescreen.so
plasma-mobile: /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_taskpanel.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/mm/libppc-mmqmlplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/private/mobileshell/libmobileshellplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/quicksetting/flashlight/libflashlightplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/quicksetting/nightcolor/libnightcolorplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/quicksetting/powermenu/libpowermenuplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/quicksetting/screenrotation/libscreenrotationplugin.so
plasma-mobile: /usr/lib64/qt5/qml/org/kde/plasma/quicksetting/screenshot/libscreenshotplugin.so

Source checksums
----------------
https://download.kde.org/stable/plasma/5.25.4/plasma-mobile-5.25.4.tar.xz :
  CHECKSUM(SHA256) this package     : 9eff8803d26b8e57f180b1a146bea3cf165fc65cb823fd6448610c49651d162c
  CHECKSUM(SHA256) upstream package : 9eff8803d26b8e57f180b1a146bea3cf165fc65cb823fd6448610c49651d162c


Requires
--------
plasma-mobile (rpmlib, GLIBC filtered):
    /usr/bin/sh
    kf5-bluez-qt
    kf5-kactivities
    kf5-kdeclarative
    kf5-kirigami2
    kwin
    libKF5ConfigCore.so.5()(64bit)
    libKF5ConfigGui.so.5()(64bit)
    libKF5ConfigWidgets.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5KIOCore.so.5()(64bit)
    libKF5KIOGui.so.5()(64bit)
    libKF5KIOWidgets.so.5()(64bit)
    libKF5ModemManagerQt.so.6()(64bit)
    libKF5NetworkManagerQt.so.6()(64bit)
    libKF5Notifications.so.5()(64bit)
    libKF5Package.so.5()(64bit)
    libKF5Plasma.so.5()(64bit)
    libKF5PlasmaQuick.so.5()(64bit)
    libKF5QuickAddons.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5WaylandClient.so.5()(64bit)
    libKF5WindowSystem.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libkworkspace5.so.5()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    plasma-milou
    plasma-nano
    plasma-nm
    plasma-nm-mobile
    plasma-pa
    plasma-workspace
    qqc2-breeze-style
    qt5-qtgraphicaleffects
    qt5-qtquickcontrols
    qt5-qtquickcontrols2
    qt5-qtwayland
    rtld(GNU_HASH)

plasma-mobile-debuginfo (rpmlib, GLIBC filtered):

plasma-mobile-debugsource (rpmlib, GLIBC filtered):



Provides
--------
plasma-mobile:
    libflashlightplugin.so()(64bit)
    libmobileshellplugin.so()(64bit)
    libnightcolorplugin.so()(64bit)
    libpowermenuplugin.so()(64bit)
    libppc-mmqmlplugin.so()(64bit)
    libscreenrotationplugin.so()(64bit)
    libscreenshotplugin.so()(64bit)
    metainfo()
    metainfo(org.kde.plasma.phone.appdata.xml)
    metainfo(org.kde.plasma.phoneshell.appdata.xml)
    plasma-mobile
    plasma-mobile(x86-64)

plasma-mobile-debuginfo:
    debuginfo(build-id)
    libflashlightplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libmobileshellplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libnightcolorplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libpowermenuplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libppc-mmqmlplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libscreenrotationplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    libscreenshotplugin.so-5.25.4-1.fc38.x86_64.debug()(64bit)
    plasma-mobile-debuginfo
    plasma-mobile-debuginfo(x86-64)

plasma-mobile-debugsource:
    plasma-mobile-debugsource
    plasma-mobile-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2065878
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: PHP, Haskell, Ocaml, Python, SugarActivity, R, fonts, Java, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Repository and branch requests made:
https://pagure.io/releng/fedora-scm-requests/issue/47250
https://pagure.io/releng/fedora-scm-requests/issue/47251
https://pagure.io/releng/fedora-scm-requests/issue/47252
https://pagure.io/releng/fedora-scm-requests/issue/47253

Unretired via https://pagure.io/releng/issue/11007