- Release should be: 1%{?dist}
- Add desktop file validation: - Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file.

Also, the spec file and the spec in the srpm differ.

Reviewing this.

- Update to the latest version and ensure SRPM is rebuilt, this one has different spec inside srpm to the one linked

- Release: 1%{dist} should be Release: 1%{?dist}

- Use desktop-file-install to install the .desktop file or desktop-file-validate to ensure it's validity

- Check with upstream if /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell/libplasmananoshellprivateplugin.so belongs in the main or devel package as it is in the main package currently and unversioned.

- SRPM/spec file differences:
--- /tmp/8493/2043940-plasma-nano/srpm/plasma-nano.spec	2022-04-15 22:08:58.915203826 +0930
+++ /tmp/8493/2043940-plasma-nano/srpm-unpacked/plasma-nano.spec	2022-01-23 03:24:42.000000000 +1030
@@ -1,5 +1,5 @@
 
 %global kf5_min_version 5.88.0
-%global orig_name org.kde.plasma.nano
+%global kde_name org.kde.plasma.nano
 
 Name:    plasma-nano
@@ -58,40 +58,40 @@
 # remove unknown tag "stock"
 # Issue track : https://invent.kde.org/plasma/plasma-nano/-/issues/4
-sed -i 's,<icon type="stock">plasma</icon>, ,g' %{buildroot}%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
-%find_lang plasma_shell_%{orig_name} --all-name
+sed -i 's,<icon type="stock">plasma</icon>, ,g' %{buildroot}%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
+%find_lang plasma_shell_%{kde_name} --all-name
 
 %check
-appstream-util validate-relax --nonet %{buildroot}%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
+appstream-util validate-relax --nonet %{buildroot}%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
 
 
-%files -f plasma_shell_%{orig_name}.lang
-%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
+%files -f plasma_shell_%{kde_name}.lang
+%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
 %{_kf5_qmldir}/org/kde/plasma/private/nanoshell/libplasmananoshellprivateplugin.so
 %{_kf5_qmldir}/org/kde/plasma/private/nanoshell/qml/StartupFeedback.qml
 %{_kf5_qmldir}/org/kde/plasma/private/nanoshell/qmldir
-%{_kf5_datadir}/kservices5/plasma-applet-%{orig_name}.desktop
-%{_kf5_datadir}/kservices5/plasma-package-%{orig_name}.desktoptoolbox.desktop
+%{_kf5_datadir}/kservices5/plasma-applet-%{kde_name}.desktop
+%{_kf5_datadir}/kservices5/plasma-package-%{kde_name}.desktoptoolbox.desktop
 
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/contents/ui/DesktopConfigButtons.qml
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/contents/ui/ToolBoxRoot.qml
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/metadata.desktop
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/metadata.json
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/AppletError.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/CompactApplet.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/DefaultCompactRepresentation.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/AppletConfiguration.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ConfigCategoryDelegate.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ConfigurationContainmentAppearance.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ContainmentConfiguration.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/defaults
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/explorer/AppletDelegate.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/explorer/WidgetExplorer.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/layout.js
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/loader.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/views/Desktop.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/views/Panel.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/contents/ui/DesktopConfigButtons.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/contents/ui/ToolBoxRoot.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/metadata.desktop
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/metadata.json
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/AppletError.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/CompactApplet.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/DefaultCompactRepresentation.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/AppletConfiguration.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ConfigCategoryDelegate.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ConfigurationContainmentAppearance.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ContainmentConfiguration.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/defaults
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/explorer/AppletDelegate.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/explorer/WidgetExplorer.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/layout.js
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/loader.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/views/Desktop.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/views/Panel.qml
 
-%{_kf5_datadir}/plasma/shells/%{orig_name}/metadata.desktop
-%{_kf5_datadir}/plasma/shells/%{orig_name}/metadata.json
+%{_kf5_datadir}/plasma/shells/%{kde_name}/metadata.desktop
+%{_kf5_datadir}/plasma/shells/%{kde_name}/metadata.json

Yes we need this;

- Check with upstream if /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell/libplasmananoshellprivateplugin.so belongs in the main or devel package as it is in the main package currently and unversioned.

I can't create desktop file because it is actually a "shell" (based on readme as we can run via "plasmashell" -> https://invent.kde.org/plasma/plasma-nano

- Use desktop-file-install to install the .desktop file or desktop-file-validate to ensure it's validity


Fixed : - Release: 1%{dist} should be Release: 1%{?dist}

sed command section also has to stay as well. 

---------
Spec URL: https://pagure.io/plasma-nano-rpm/raw/main/f/plasma-nano.spec
SRPM URL: https://pagure.io/plasma-nano-rpm/raw/main/f/plasma-nano-5.24.4-1.fc36.src.rpm

- Include the licenses folder in %files

- With regards to desktop-file-validate only 2 of the 4 fail, the others should be able to be validated and the make note that the others have been reported upstream:
./usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/metadata.desktop: error: file contains multiple keys named "X-KDE-PluginInfo-Version" in group "Desktop Entry"
./usr/share/kservices5/plasma-package-org.kde.plasma.nano.desktoptoolbox.desktop: error: file contains multiple keys named "X-KDE-PluginInfo-Version" in group "Desktop Entry"

find . -iname "*.desktop"
./usr/share/plasma/shells/org.kde.plasma.nano/metadata.desktop
./usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/metadata.desktop
./usr/share/kservices5/plasma-package-org.kde.plasma.nano.desktoptoolbox.desktop
./usr/share/kservices5/plasma-applet-org.kde.plasma.nano.desktop

- Make note in %files section that unversioned so file is required (confirmed by upstream)

- The review.txt mentions some folders aren't owned by the package, I assume because they're not listed in the %files section:
     /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell
     /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell/qml
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents/ui
     /usr/share/plasma/shells/org.kde.plasma.nano
     /usr/share/plasma/shells/org.kde.plasma.nano/contents
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/applet
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/configuration
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/explorer
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/views

Regarding the two that fail I have reported upstream @ https://invent.kde.org/plasma/plasma-nano/-/issues/5 so you can include that in your comments in the file near the other validation.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

New version added.
dir sections added for ownership problem.
license and doc section added. License part updated based on files I saw on license folder It should be fine.
sed command still has to stay based on latest version It still gives me error so I'm gonna keep it. (for validate)


SPEC : https://pagure.io/plasma-nano-rpm/raw/main/f/plasma-nano.spec 
SRPM : https://pagure.io/plasma-nano-rpm/raw/main/f/plasma-nano-5.25.4-1.fc36.src.rpm

Looks good, approving, just add ownership of these using %{dir} before submitting to repo:
/usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents,
/usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents/ui
/usr/share/plasma/shells/org.kde.plasma.nano/contents
/usr/share/plasma/shells/org.kde.plasma.nano/contents/applet
/usr/share/plasma/shells/org.kde.plasma.nano/contents/configuration
/usr/share/plasma/shells/org.kde.plasma.nano/contents/explorer
/usr/share/plasma/shells/org.kde.plasma.nano/contents/views

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-nano

FEDORA-2022-747a5d4338 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-747a5d4338

FEDORA-2022-747a5d4338 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-747a5d4338 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-747a5d4338

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-46ba30bcad has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-46ba30bcad`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-46ba30bcad

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-46ba30bcad has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.