Bug 2070053

Description of problem:

Removal of a network that is mapped to a VDSM UUID fails.
Well actually it completes successfully, but no command is send to VDSM, so the bridge is never deleted.

Our setup is the following:
All hosts have 4 nics
2 nics in bond0 -> labeled ACCESS
2 nics in bond1 -> labeled STORAGE


How reproducible:
Always with networks mapped to a VDSM UUID

Steps to Reproduce:
1. Create a new network with a name long enough to get mapped to a VDSM UUID
2. Network is created correctly
3. Remove the network
4. Network removal is completed without errors
5. Check the host, it still contains the VDSM UUID named bridge

Additional info:
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-9) [cd953205-a0f9-43cb-b302-9735098f9fb9] No changes were detected in setup networks for host 'ovn001' (ID: 'a490f769-059c-4ff5-8c73-ff4cd2049383')
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-13) [cd953205-a0f9-43cb-b302-9735098f9fb9] Running command: HostSetupNetworksCommand(Labels = [], EmptyRequest = true, ConectivityTimeout = null, NetworkAttachments = [], RemovedLabels = [], CommitOnSuccess = true, RemovedNetworkAttachments = [], CreateOrUpdateBonds = [], RemovedBonds = [], RemovedUnmanagedNetworks = [], VdsId = 7556b4e2-2faf-4511-954f-26291c6e66f2, RunSilent = false) internal: true. Entities affected :  ID: 7556b4e2-2faf-4511-954f-26291c6e66f2 Type: VDSAction group CONFIGURE_HOST_NETWORK with role type ADMIN

This shows the request is just empty, as it failed to create mappins in https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java#L40

When you execute the command with a short-named network, it works, but just because the fallback does its job, not because mapping works there:
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-19) [0bb0c98d-88d5-4ff3-83b8-37535954fc64] Running command: HostSetupNetworksCommand(Labels = [], EmptyRequest = false, ConectivityTimeout = null, NetworkAttachments = [], RemovedLabels = [], CommitOnSuccess = true, RemovedNetworkAttachments = [], CreateOrUpdateBonds = [], RemovedBonds = [], RemovedUnmanagedNetworks = [TEST], VdsId = 98686bb0-265a-4d06-bc32-208d8cd10e5c, RunSilent = false) internal: true. Entities affected :  ID: 98686bb0-265a-4d06-bc32-208d8cd10e5c Type: VDSAction group CONFIGURE_HOST_NETWORK with role type ADMIN

You see it gets removed because it was added to 'RemovedUnmanagedNetworks', but not because proper mapping was passed.