Bug 2070053 - Removal of a labeled long network(more than 15 characters) is incomplete
Summary: Removal of a labeled long network(more than 15 characters) is incomplete
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.4.10.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.5.0
: 4.5.0.1
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-30 11:32 UTC by Jean-Louis Dupond
Modified: 2022-04-22 15:06 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-4.5.0.1
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-22 15:06:04 UTC
oVirt Team: Network
Embargoed:
mperina: ovirt-4.5+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-engine pull 206 0 None open core: Fix removal of unmanaged network with long name 2022-03-30 11:49:41 UTC
Red Hat Issue Tracker RHV-45482 0 None None None 2022-03-30 11:43:56 UTC

Description Jean-Louis Dupond 2022-03-30 11:32:46 UTC
Description of problem:

Removal of a network that is mapped to a VDSM UUID fails.
Well actually it completes successfully, but no command is send to VDSM, so the bridge is never deleted.

Our setup is the following:
All hosts have 4 nics
2 nics in bond0 -> labeled ACCESS
2 nics in bond1 -> labeled STORAGE


How reproducible:
Always with networks mapped to a VDSM UUID

Steps to Reproduce:
1. Create a new network with a name long enough to get mapped to a VDSM UUID
2. Network is created correctly
3. Remove the network
4. Network removal is completed without errors
5. Check the host, it still contains the VDSM UUID named bridge

Additional info:
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-9) [cd953205-a0f9-43cb-b302-9735098f9fb9] No changes were detected in setup networks for host 'ovn001' (ID: 'a490f769-059c-4ff5-8c73-ff4cd2049383')
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-13) [cd953205-a0f9-43cb-b302-9735098f9fb9] Running command: HostSetupNetworksCommand(Labels = [], EmptyRequest = true, ConectivityTimeout = null, NetworkAttachments = [], RemovedLabels = [], CommitOnSuccess = true, RemovedNetworkAttachments = [], CreateOrUpdateBonds = [], RemovedBonds = [], RemovedUnmanagedNetworks = [], VdsId = 7556b4e2-2faf-4511-954f-26291c6e66f2, RunSilent = false) internal: true. Entities affected :  ID: 7556b4e2-2faf-4511-954f-26291c6e66f2 Type: VDSAction group CONFIGURE_HOST_NETWORK with role type ADMIN

This shows the request is just empty, as it failed to create mappins in https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java#L40

When you execute the command with a short-named network, it works, but just because the fallback does its job, not because mapping works there:
INFO  [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (EE-ManagedThreadFactory-engine-Thread-19) [0bb0c98d-88d5-4ff3-83b8-37535954fc64] Running command: HostSetupNetworksCommand(Labels = [], EmptyRequest = false, ConectivityTimeout = null, NetworkAttachments = [], RemovedLabels = [], CommitOnSuccess = true, RemovedNetworkAttachments = [], CreateOrUpdateBonds = [], RemovedBonds = [], RemovedUnmanagedNetworks = [TEST], VdsId = 98686bb0-265a-4d06-bc32-208d8cd10e5c, RunSilent = false) internal: true. Entities affected :  ID: 98686bb0-265a-4d06-bc32-208d8cd10e5c Type: VDSAction group CONFIGURE_HOST_NETWORK with role type ADMIN

You see it gets removed because it was added to 'RemovedUnmanagedNetworks', but not because proper mapping was passed.

Comment 1 Ales Musil 2022-03-30 11:37:42 UTC
One thing to note, the network must have label that is present on the host, so the automatic mechanism for removal kicks in.

Comment 2 RHEL Program Management 2022-03-30 11:37:49 UTC
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 4 Michael Burman 2022-04-20 13:21:25 UTC
Verified on - rhvm-4.5.0.2-0.7.el8ev.noarch and vdsm-4.50.0.12-1.el8ev.x86_64

Comment 5 Sandro Bonazzola 2022-04-22 15:06:04 UTC
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.