Bug 2070549

Summary:	Review Request: python-virt-firmware - tools for virtual machine firmware volumes
Product:	[Fedora] Fedora	Reporter:	Gerd Hoffmann <kraxel>
Component:	Package Review	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	crobinso, package-review
Target Milestone:	---	Flags:	crobinso: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-14 14:57:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gerd Hoffmann 2022-03-31 12:25:09 UTC

Spec URL: https://kraxel.gitlab.io/virt-firmware/rpms/src/python-virt-firmware.spec
SRPM URL: https://kraxel.gitlab.io/virt-firmware/rpms/src/python-virt-firmware-0.95-1.fc35.src.rpm
Description: tools for virtual machine firmware volumes
Fedora Account System Username: kraxel

Comment 1 Cole Robinson 2022-04-10 16:14:44 UTC

* Change URL field to URL: https://gitlab.com/kraxel/virt-firmware
* Change Source0 to Source0: https://gitlab.com/kraxel/virt-firmware/-/archive/v0.95/virt-firmware-v0.95.tar.gz

* package needs to own the dir /usr/lib/python3.10/site-packages/virt

* username in changelog should be fixed
* upstream project should include a license, and it should be included in the package
* the %description is wonky. give it a review. there's also a typo there: certifiactes

* rpmlint: python-virt-firmware.src: W: summary-not-capitalized tools for virtual machine firmware volumes

Comment 2 Gerd Hoffmann 2022-04-11 11:11:41 UTC

Ok, seems the pyp2rpm-generated version has enough shortcomings that I need a hand-crafted instead of auto-generated one ...
So, here we go: https://www.kraxel.org/review/

Comment 3 Cole Robinson 2022-04-11 13:33:56 UTC

Looks good, approved.

Optional: You can use a macro to share the duplicate description, like rust2rpm packages do. Example here, the format is a little weird: https://src.fedoraproject.org/rpms/rust-capng/blob/rawhide/f/rust-capng.spec

Comment 4 Gwyn Ciesla 2022-04-13 13:35:19 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-virt-firmware

Comment 5 Cole Robinson 2022-06-14 14:57:54 UTC

In git now