Spec URL: https://kraxel.gitlab.io/virt-firmware/rpms/src/python-virt-firmware.spec SRPM URL: https://kraxel.gitlab.io/virt-firmware/rpms/src/python-virt-firmware-0.95-1.fc35.src.rpm Description: tools for virtual machine firmware volumes Fedora Account System Username: kraxel
* Change URL field to URL: https://gitlab.com/kraxel/virt-firmware * Change Source0 to Source0: https://gitlab.com/kraxel/virt-firmware/-/archive/v0.95/virt-firmware-v0.95.tar.gz * package needs to own the dir /usr/lib/python3.10/site-packages/virt * username in changelog should be fixed * upstream project should include a license, and it should be included in the package * the %description is wonky. give it a review. there's also a typo there: certifiactes * rpmlint: python-virt-firmware.src: W: summary-not-capitalized tools for virtual machine firmware volumes
Ok, seems the pyp2rpm-generated version has enough shortcomings that I need a hand-crafted instead of auto-generated one ... So, here we go: https://www.kraxel.org/review/
Looks good, approved. Optional: You can use a macro to share the duplicate description, like rust2rpm packages do. Example here, the format is a little weird: https://src.fedoraproject.org/rpms/rust-capng/blob/rawhide/f/rust-capng.spec
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-virt-firmware
In git now