Bug 2071547

Summary: Review Request: obs-service-cargo_vendor - An OBS source service: Download, verify and vendor Rust crates (libraries)
Product: [Fedora] Fedora Reporter: Dan Čermák <dan.cermak>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-05 07:20:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Čermák 2022-04-04 07:41:29 UTC 
Spec URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor.spec
SRPM URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor-0.4.3-1.fc35.src.rpm
Description: An OBS Source Service that will download, verify and vendor Rust crates (libraries)
Fedora Account System Username: defolos

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=85142840
Comment 1 Neal Gompa 2022-04-04 11:58:25 UTC 
Taking this review.
Comment 2 Neal Gompa 2022-04-04 11:59:08 UTC 
> Requires:       (cargo or rustup)

Please drop the dependency on rustup. It doesn't exist and package dependencies need to exist in the distribution.
Comment 3 Neal Gompa 2022-04-04 12:00:04 UTC 
> Source:         %{URL}/archive/refs/tags/v%{version}.tar.gz#./%{name}-%{version}.tar.gz

Please fix to the correct SourceURL format. "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
Comment 4 Dan Čermák 2022-04-04 14:17:26 UTC 
I have addressed both issues.
Comment 5 Neal Gompa 2022-08-26 12:49:54 UTC 
Review notes:

* Package builds and installs
* Package naming complies with the guidelines
* Package licensing is correct and license file is installed

There is one minor issue: I'd advise you fix the file list so that you correctly own your OBS service content:

Either:
%dir %{_prefix}/lib/obs/service
%{_prefix}/lib/obs/service/*

Or:
%{_prefix}/lib/obs/service/

It's trivial to fix on import, so I'll let you do that then.

PACKAGE APPROVED.
Comment 6 Gwyn Ciesla 2022-08-26 13:20:06 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-cargo_vendor
Comment 7 Package Review 2023-09-05 07:20:26 UTC 
Package is now in repositories, closing review.