Spec URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor.spec SRPM URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor-0.4.3-1.fc35.src.rpm Description: An OBS Source Service that will download, verify and vendor Rust crates (libraries) Fedora Account System Username: defolos Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=85142840
Taking this review.
> Requires: (cargo or rustup) Please drop the dependency on rustup. It doesn't exist and package dependencies need to exist in the distribution.
> Source: %{URL}/archive/refs/tags/v%{version}.tar.gz#./%{name}-%{version}.tar.gz Please fix to the correct SourceURL format. "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
I have addressed both issues.
Review notes: * Package builds and installs * Package naming complies with the guidelines * Package licensing is correct and license file is installed There is one minor issue: I'd advise you fix the file list so that you correctly own your OBS service content: Either: %dir %{_prefix}/lib/obs/service %{_prefix}/lib/obs/service/* Or: %{_prefix}/lib/obs/service/ It's trivial to fix on import, so I'll let you do that then. PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-cargo_vendor
Package is now in repositories, closing review.