Bug 2072106

Summary:	cluster-ingress-operator tests do not build on go 1.18
Product:	OpenShift Container Platform	Reporter:	Omer Tuchfeld <otuchfel>
Component:	Networking	Assignee:	Miciah Dashiel Butler Masters <mmasters>
Networking sub component:	router	QA Contact:	Melvin Joseph <mjoseph>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, hongli, mmasters
Version:	4.11
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 11:03:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Omer Tuchfeld 2022-04-05 15:46:10 UTC

Description of problem:
Trying to build/run cluster-ingress-operator tests `go test ./...` leads to errors due to a regression in the standard testing package of golang between 1.17 and 1.18

OpenShift release version:
n/a

Cluster Platform:
n/a


How reproducible:
Always

Steps to Reproduce (in detail):
1. clone cluster-ingress-operator
2. go test ./...
3.


Actual results:
Tests fail to build

Expected results:
Tests should build and run

Impact of the problem:
Cannot run tests with a go 1.18 toolchain

Additional info:
None

Comment 3 Melvin Joseph 2022-04-12 09:11:56 UTC

melvinjoseph@mjoseph-mac Git  Repos % git clone https://github.com/openshift/cluster-ingress-operator.git
Cloning into 'cluster-ingress-operator'...
remote: Enumerating objects: 40158, done.
remote: Counting objects: 100% (3957/3957), done.
remote: Compressing objects: 100% (1707/1707), done.
remote: Total 40158 (delta 2514), reused 2745 (delta 2168), pack-reused 36201
Receiving objects: 100% (40158/40158), 78.62 MiB | 6.61 MiB/s, done.
Resolving deltas: 100% (21809/21809), done.
Updating files: 100% (5799/5799), done.

melvinjoseph@mjoseph-mac Git  Repos % go version
go version go1.18 darwin/amd64

melvinjoseph@mjoseph-mac Git  Repos % cd cluster-ingress-operator 
melvinjoseph@mjoseph-mac cluster-ingress-operator % go test ./...
?   	github.com/openshift/cluster-ingress-operator/cmd/ingress-operator	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/dns	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/alibaba	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/alibaba/util	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/aws	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/azure	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/azure/client	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/dns/gcp	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/ibm	1.272s
?   	github.com/openshift/cluster-ingress-operator/pkg/dns/ibm/client	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/log	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/manifests	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/operator	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/client	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/config	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/canary	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/certificate	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/certificate-publisher	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/clientca-configmap	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/configurable-route	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/crl	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/dns	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/ingress	1.278s
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/ingressclass	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/status	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/sync-http-error-code-configmap	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util/aws	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util/retryableerror	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/util/slice	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/grpc	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/h2spec	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/http	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/http2	[no test files]
melvinjoseph@mjoseph-mac cluster-ingress-operator % 

Hence moving as verified

Comment 5 errata-xmlrpc 2022-08-10 11:03:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069