Bug 2072106 - cluster-ingress-operator tests do not build on go 1.18
Summary: cluster-ingress-operator tests do not build on go 1.18
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.11
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.11.0
Assignee: Miciah Dashiel Butler Masters
QA Contact: Melvin Joseph
Depends On:
TreeView+ depends on / blocked
Reported: 2022-04-05 15:46 UTC by Omer Tuchfeld
Modified: 2022-08-10 11:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Last Closed: 2022-08-10 11:03:38 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift cluster-ingress-operator pull 733 0 None open Bug 2072106: Fix test `Errorf` limitation in go 1.18 2022-04-05 15:46:48 UTC

Description Omer Tuchfeld 2022-04-05 15:46:10 UTC
Description of problem:
Trying to build/run cluster-ingress-operator tests `go test ./...` leads to errors due to a regression in the standard testing package of golang between 1.17 and 1.18

OpenShift release version:

Cluster Platform:

How reproducible:

Steps to Reproduce (in detail):
1. clone cluster-ingress-operator
2. go test ./...

Actual results:
Tests fail to build

Expected results:
Tests should build and run

Impact of the problem:
Cannot run tests with a go 1.18 toolchain

Additional info:

Comment 3 Melvin Joseph 2022-04-12 09:11:56 UTC
melvinjoseph@mjoseph-mac Git  Repos % git clone https://github.com/openshift/cluster-ingress-operator.git
Cloning into 'cluster-ingress-operator'...
remote: Enumerating objects: 40158, done.
remote: Counting objects: 100% (3957/3957), done.
remote: Compressing objects: 100% (1707/1707), done.
remote: Total 40158 (delta 2514), reused 2745 (delta 2168), pack-reused 36201
Receiving objects: 100% (40158/40158), 78.62 MiB | 6.61 MiB/s, done.
Resolving deltas: 100% (21809/21809), done.
Updating files: 100% (5799/5799), done.

melvinjoseph@mjoseph-mac Git  Repos % go version
go version go1.18 darwin/amd64

melvinjoseph@mjoseph-mac Git  Repos % cd cluster-ingress-operator 
melvinjoseph@mjoseph-mac cluster-ingress-operator % go test ./...
?   	github.com/openshift/cluster-ingress-operator/cmd/ingress-operator	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/dns	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/alibaba	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/alibaba/util	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/aws	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/azure	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/azure/client	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/dns/gcp	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/dns/ibm	1.272s
?   	github.com/openshift/cluster-ingress-operator/pkg/dns/ibm/client	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/log	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/manifests	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/operator	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/client	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/config	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/canary	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/certificate	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/certificate-publisher	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/clientca-configmap	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/configurable-route	[no test files]
?   	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/crl	[no test files]
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/dns	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/ingress	1.278s
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/ingressclass	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/status	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/operator/controller/sync-http-error-code-configmap	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util/aws	(cached)
ok  	github.com/openshift/cluster-ingress-operator/pkg/util/retryableerror	(cached)
?   	github.com/openshift/cluster-ingress-operator/pkg/util/slice	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/grpc	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/h2spec	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/http	[no test files]
?   	github.com/openshift/cluster-ingress-operator/test/http2	[no test files]
melvinjoseph@mjoseph-mac cluster-ingress-operator % 

Hence moving as verified

Comment 5 errata-xmlrpc 2022-08-10 11:03:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.