Bug 2072428

Summary: Review Request: python-vcert - Automate key generation and certificate enrollment using Venafi machine identity services
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: loganjerry, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2091915    
Bug Blocks:    

Description Dominik 'Rathann' Mierzejewski 2022-04-06 09:42:56 UTC
Spec URL: https://rathann.fedorapeople.org/review/python-vcert/python-vcert.spec
SRPM URL: https://rathann.fedorapeople.org/review/python-vcert/python-vcert-0.14.0-1.fc35.src.rpm

Description:
VCert Python is a Python library and SDK designed to simplify key generation and 
enrollment of machine identities (also known as SSL/TLS certificates and keys)
that comply with enterprise security policy by using the Venafi Trust Protection
Platform or Venafi as a Service.

Fedora Account System Username: rathann

Comment 1 Jerry James 2022-04-12 23:51:21 UTC
I will take this review.

Comment 2 Jerry James 2022-04-13 00:58:21 UTC
Same problem as with python-mrcfile when building for Rawhide:

+ cd vcert-python-0.14.0
+ %py3_build
RPM build errors:
/var/tmp/rpm-tmp.WQSUwx: line 42: fg: no job control
error: Bad exit status from /var/tmp/rpm-tmp.WQSUwx (%build)

Can %pyproject_wheel and %pyproject_install be used?

Comment 3 Dominik 'Rathann' Mierzejewski 2022-04-13 12:46:42 UTC
Builds fine for me in rawhide mock. Have you tried scrubbing your mock rawhide buildroot and retrying?

Similar to mrcfile, this project doesn't have pyproject.toml file, only setup.py.

Comment 4 Jerry James 2022-04-14 04:37:43 UTC
Yes, that was the problem.  The package builds fine now, but cannot be installed:

Error: 
 Problem: conflicting requests
  - nothing provides python3.10dist(certvalidator) <= 0.11.1 needed by python3-vcert-0.14.0-1.fc37.noarch
  - nothing provides python3.10dist(cryptography) = 36.0.1 needed by python3-vcert-0.14.0-1.fc37.noarch
  - nothing provides python3.10dist(pynacl) = 1.5 needed by python3-vcert-0.14.0-1.fc37.noarch
  - nothing provides python3.10dist(ruamel-yaml) = 0.17.20 needed by python3-vcert-0.14.0-1.fc37.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Comment 5 Dominik 'Rathann' Mierzejewski 2022-05-06 20:50:45 UTC
It turns out I need two more packages: python-certvalidator and python-oscrypto. I'll submit review bugs shortly.

Comment 6 Dominik 'Rathann' Mierzejewski 2022-05-31 10:22:02 UTC
Spec URL: https://rathann.fedorapeople.org/review/python-vcert/python-vcert.spec
SRPM URL: https://rathann.fedorapeople.org/review/python-vcert/python-vcert-0.14.0-2.fc36.src.rpm

* Fri May 06 2022 Dominik Mierzejewski <dominik> 0.14.0-2
- relax dependency versions

Comment 7 Package Review 2023-06-01 00:45:30 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 8 Package Review 2023-07-02 00:45:28 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.