Bug 2091915 - Review Request: python-certvalidator - Validate X.509 certificates and paths
Summary: Review Request: python-certvalidator - Validate X.509 certificates and paths
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2091916
Blocks: 2072428
TreeView+ depends on / blocked
 
Reported: 2022-05-31 10:18 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2024-12-30 22:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-30 22:10:05 UTC
Type: ---
Embargoed:
orion: fedora-review?


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2022-05-31 10:18:19 UTC
Spec URL: https://rathann.fedorapeople.org/review/python-certvalidator/python-certvalidator.spec
SRPM URL: https://rathann.fedorapeople.org/review/python-certvalidator/python-certvalidator-0.11.1-1.fc36.src.rpm
Description:
A Python library for validating X.509 certificates or paths. Supports
various options, including: validation at a specific moment in time,
whitelisting and revocation checks.

Fedora Account System Username: rathann

Comment 1 Package Review 2023-06-01 00:45:32 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 2 Dominik 'Rathann' Mierzejewski 2023-06-05 07:19:38 UTC
This is still open for review.

Comment 3 Orion Poplawski 2023-11-29 03:34:49 UTC
Package fails to build with lots of test errors, e.g.:

+ python3 -m unittest tests/test_certificate_validator.py tests/test_ocsp_client.py tests/test_registry.py tests/test_validate.py
EEEEEEE..EE..EEE..EEE.EE.........EEEEEE.EEEEE..E..E.EE.E..E.EEEEE.EE..EEEE...E.EE.EE..EE.EEE..E....E.E.EEEEEE.E...E.E.EE.EEEEE..EEE.E.E.EE..E.EE.EE.EEEE..EE.E..EE...EE.EEE.EE.E..EE.EEEEEEE.EEEEEE.EEEE.EEEEEEEE.EE
======================================================================
ERROR: test_basic_certificate_validator_tls (tests.test_certificate_validator.CertificateValidatorTests.test_basic_certificate_validator_tls)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/certvalidator-0.11.1/tests/test_certificate_validator.py", line 44, in test_basic_certificate_validator_tls
    path = validator.validate_tls('codexns.io')
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/certvalidator-0.11.1/certvalidator/__init__.py", line 222, in validate_tls
    self._validate_path()
  File "/builddir/build/BUILD/certvalidator-0.11.1/certvalidator/__init__.py", line 108, in _validate_path
    paths = self._context.certificate_registry.build_paths(self._certificate)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/certvalidator-0.11.1/certvalidator/registry.py", line 314, in build_paths
    raise PathBuildingError(pretty_message(
certvalidator.errors.PathBuildingError: Unable to build a validation path for the certificate "Common Name: codexns.io, Organization: Codex Non Sufficit LC, Locality: Newbury, State/Province: Massachusetts, Country: US, Serial Number: 471714639, Business Category: Private Organization, Incorporation State/Province: Massachusetts, Incorporation Country: US" - no issuer matching "Common Name: GeoTrust Primary Certification Authority, Organization: GeoTrust Inc., Country: US" was found
======================================================================
ERROR: test_basic_certificate_validator_tls_expired (tests.test_certificate_validator.CertificateValidatorTests.test_basic_certificate_validator_tls_expired)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/certvalidator-0.11.1/tests/test_certificate_validator.py", line 53, in test_basic_certificate_validator_tls_expired
    with self.assertRaisesRegexp(PathValidationError, 'expired'):
         ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'CertificateValidatorTests' object has no attribute 'assertRaisesRegexp'. Did you mean: 'assertRaisesRegex'?

There hasn't been a release in over 7 years, are you sure this is needed?

Comment 4 Package Review 2024-11-29 00:45:28 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 5 Dominik 'Rathann' Mierzejewski 2024-12-30 22:10:05 UTC
I'm no longer interested in packaging this. Closing review request. Thanks for your efforts so far, Orion. Happy New Year!


Note You need to log in before you can comment on or make changes to this bug.