Bug 2073377
| Summary: | Review Request: perl-Parse-Distname - Parse a distribution name | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Michal Josef Spacek <mspacek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mspacek, package-review |
| Target Milestone: | --- | Flags: | mspacek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Parse-Distname-0.05-2.fc37 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-12 01:12:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2079764 | ||
|
Description
Paul Howarth
2022-04-08 11:10:00 UTC
@paul "BuildRequires: coreutils" It is not needed, sure? "BuildRequires: perl(strict)" You could move to "Module Runtime" section "%doc Changes README t/" No contain t/ in doc (In reply to Michal Josef Spacek from comment #1) > @paul > > "BuildRequires: coreutils" > It is not needed, sure? %{_fixperms} in the %install section is implemented using chmod from coreutils. > "BuildRequires: perl(strict)" > You could move to "Module Runtime" section Yes, you're right, it should be there. > "%doc Changes README t/" > No contain t/ in doc I don't usually package the tests. It's a habit from a long time ago when you could get additional dependencies from documentation files. I'm open to persuasion on this. (In reply to Paul Howarth from comment #2) > (In reply to Michal Josef Spacek from comment #1) > > @paul > > > > "BuildRequires: coreutils" > > It is not needed, sure? > > %{_fixperms} in the %install section is implemented using chmod from > coreutils. Ah, ok. > > "%doc Changes README t/" > > No contain t/ in doc > > I don't usually package the tests. It's a habit from a long time ago when > you could get additional dependencies from documentation files. > I'm open to persuasion on this. That's no about test packaging. We don't package test files in main package. I use grep to mine packages and there is no case for it. Option is only extra package for tests. (In reply to Michal Josef Spacek from comment #3) > (In reply to Paul Howarth from comment #2) > > (In reply to Michal Josef Spacek from comment #1) > > > "%doc Changes README t/" > > > No contain t/ in doc > > > > I don't usually package the tests. It's a habit from a long time ago when > > you could get additional dependencies from documentation files. > > I'm open to persuasion on this. > > That's no about test packaging. We don't package test files in main package. > I use grep to mine packages and there is no case for it. > > Option is only extra package for tests. Ah, I see what you mean. I did actually have "%doc Changes README t/", which is unusual for me. I must have based my spec file on another package that included the tests like that. I'll drop the "t/" from the "%doc" line. (In reply to Paul Howarth from comment #4) > Ah, I see what you mean. I did actually have "%doc Changes README t/", which > is unusual for me. I must have based my spec file on another package that > included the tests like that. I'll drop the "t/" from the "%doc" line. yes. Please, update files. SRPM URL: http://www.city-fan.org/~paul/extras/perl-Parse-Distname/perl-Parse-Distname-0.05-2.fc37.src.rpm Spec URL is unchanged. Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
$ rpm -qp --requires perl-Parse-Distname-0.05-2.fc37.noarch.rpm | sort | uniq -c | grep -v rpmlib
1 perl(Carp)
1 perl(Exporter) >= 5.57
1 perl(:MODULE_COMPAT_5.34.1)
1 perl(strict)
1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --provides perl-Parse-Distname-0.05-2.fc37.noarch.rpm |sort | uniq -c
1 perl(Parse::Distname) = 0.05
1 perl-Parse-Distname = 0.05-2.fc37
Binary provides are Ok.
$ rpmlint ./perl-Parse-Distname*
2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s
Rpmlint is ok
The package is in line with Fedora and Perl packaging guide lines.
Resolution:
The package can be approved.
Thanks, Michal. $ fedpkg request-branch epel9 https://pagure.io/releng/fedora-scm-requests/issue/44142 $ fedpkg request-repo perl-Parse-Distname 2073377 https://pagure.io/releng/fedora-scm-requests/issue/44143 $ fedpkg request-branch --repo perl-Parse-Distname f36 https://pagure.io/releng/fedora-scm-requests/issue/44144 $ fedpkg request-branch --repo perl-Parse-Distname f35 https://pagure.io/releng/fedora-scm-requests/issue/44145 $ fedpkg request-branch --repo perl-Parse-Distname f34 https://pagure.io/releng/fedora-scm-requests/issue/44146 $ fedpkg request-branch --repo perl-Parse-Distname epel9 https://pagure.io/releng/fedora-scm-requests/issue/44147 $ fedpkg request-branch --repo perl-Parse-Distname epel8 https://pagure.io/releng/fedora-scm-requests/issue/44148 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Parse-Distname FEDORA-EPEL-2022-72f5f51db3 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-72f5f51db3 FEDORA-2022-8debd65f1c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8debd65f1c FEDORA-2022-419c129c95 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-419c129c95 FEDORA-2022-8debd65f1c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8debd65f1c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8debd65f1c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-133941f2cb has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-133941f2cb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-133941f2cb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2022-8cdac2641e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-8cdac2641e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-419c129c95 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-419c129c95 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-419c129c95 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2022-72f5f51db3 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-72f5f51db3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-8debd65f1c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-133941f2cb has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2022-8cdac2641e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-419c129c95 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2022-72f5f51db3 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |