Bug 2073377 - Review Request: perl-Parse-Distname - Parse a distribution name
Summary: Review Request: perl-Parse-Distname - Parse a distribution name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Josef Spacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2079764
TreeView+ depends on / blocked
 
Reported: 2022-04-08 11:10 UTC by Paul Howarth
Modified: 2022-05-12 03:35 UTC (History)
2 users (show)

Fixed In Version: perl-Parse-Distname-0.05-2.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-12 01:12:31 UTC
Type: ---
Embargoed:
mspacek: fedora-review+


Attachments (Terms of Use)

Description Paul Howarth 2022-04-08 11:10:00 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Parse-Distname/branches/fedora/perl-Parse-Distname.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Parse-Distname/perl-Parse-Distname-0.05-1.fc37.src.rpm

Description:
Parse::Distname is yet another distribution name parser. It works almost the
same as CPAN::DistnameInfo, but Parse::Distname takes a different approach. It
tries to extract the version part of a distribution and treat the rest as a
distribution name, contrary to CPAN::DistnameInfo which tries to define a name
part and treat the rest as a version.

Because of this difference, when Parse::Distname parses a weird distribution
name such as "AUTHOR/v1.0.tar.gz", it says the name is empty and the version
is "v1.0", while CPAN::DistnameInfo says the name is "v" and the version is
"1.0". See test files in this distribution if you need more details. As of this
writing, Parse::Distname returns a different result for about 200+
distributions among about 320000 BackPan distributions.

Fedora Account System Username: pghmcfc

This package is a requirement for updating perl-Perl-PrereqScanner-NotQuiteLite to the current upstream version (0.9916).

Comment 1 Michal Josef Spacek 2022-04-28 11:42:24 UTC
@paul 

"BuildRequires:  coreutils"
It is not needed, sure?

"BuildRequires:  perl(strict)"
You could move to "Module Runtime" section

"%doc Changes README t/"
No contain t/ in doc

Comment 2 Paul Howarth 2022-04-28 11:52:07 UTC
(In reply to Michal Josef Spacek from comment #1)
> @paul 
> 
> "BuildRequires:  coreutils"
> It is not needed, sure?

%{_fixperms} in the %install section is implemented using chmod from coreutils.

> "BuildRequires:  perl(strict)"
> You could move to "Module Runtime" section

Yes, you're right, it should be there.

> "%doc Changes README t/"
> No contain t/ in doc

I don't usually package the tests. It's a habit from a long time ago when you could get additional dependencies from documentation files.
I'm open to persuasion on this.

Comment 3 Michal Josef Spacek 2022-04-28 12:52:05 UTC
(In reply to Paul Howarth from comment #2)
> (In reply to Michal Josef Spacek from comment #1)
> > @paul 
> > 
> > "BuildRequires:  coreutils"
> > It is not needed, sure?
> 
> %{_fixperms} in the %install section is implemented using chmod from
> coreutils.

Ah, ok.

> > "%doc Changes README t/"
> > No contain t/ in doc
> 
> I don't usually package the tests. It's a habit from a long time ago when
> you could get additional dependencies from documentation files.
> I'm open to persuasion on this.

That's no about test packaging. We don't package test files in main package.
I use grep to mine packages and there is no case for it.

Option is only extra package for tests.

Comment 4 Paul Howarth 2022-04-28 12:59:39 UTC
(In reply to Michal Josef Spacek from comment #3)
> (In reply to Paul Howarth from comment #2)
> > (In reply to Michal Josef Spacek from comment #1)
> > > "%doc Changes README t/"
> > > No contain t/ in doc
> > 
> > I don't usually package the tests. It's a habit from a long time ago when
> > you could get additional dependencies from documentation files.
> > I'm open to persuasion on this.
> 
> That's no about test packaging. We don't package test files in main package.
> I use grep to mine packages and there is no case for it.
> 
> Option is only extra package for tests.

Ah, I see what you mean. I did actually have "%doc Changes README t/", which is unusual for me. I must have based my spec file on another package that included the tests like that. I'll drop the "t/" from the "%doc" line.

Comment 5 Michal Josef Spacek 2022-04-28 15:29:52 UTC
(In reply to Paul Howarth from comment #4)
> Ah, I see what you mean. I did actually have "%doc Changes README t/", which
> is unusual for me. I must have based my spec file on another package that
> included the tests like that. I'll drop the "t/" from the "%doc" line.

yes.

Please, update files.

Comment 6 Paul Howarth 2022-04-28 16:16:58 UTC
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Parse-Distname/perl-Parse-Distname-0.05-2.fc37.src.rpm

Spec URL is unchanged.

Comment 7 Michal Josef Spacek 2022-05-02 13:50:16 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Parse-Distname-0.05-2.fc37.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Exporter) >= 5.57
      1 perl(:MODULE_COMPAT_5.34.1)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Parse-Distname-0.05-2.fc37.noarch.rpm |sort | uniq -c
      1 perl(Parse::Distname) = 0.05
      1 perl-Parse-Distname = 0.05-2.fc37
Binary provides are Ok.

$ rpmlint ./perl-Parse-Distname*
2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
The package can be approved.

Comment 8 Paul Howarth 2022-05-03 06:55:51 UTC
Thanks, Michal.

$ fedpkg request-branch epel9
https://pagure.io/releng/fedora-scm-requests/issue/44142
$ fedpkg request-repo perl-Parse-Distname 2073377
https://pagure.io/releng/fedora-scm-requests/issue/44143
$ fedpkg request-branch --repo perl-Parse-Distname f36
https://pagure.io/releng/fedora-scm-requests/issue/44144
$ fedpkg request-branch --repo perl-Parse-Distname f35
https://pagure.io/releng/fedora-scm-requests/issue/44145
$ fedpkg request-branch --repo perl-Parse-Distname f34
https://pagure.io/releng/fedora-scm-requests/issue/44146
$ fedpkg request-branch --repo perl-Parse-Distname epel9
https://pagure.io/releng/fedora-scm-requests/issue/44147
$ fedpkg request-branch --repo perl-Parse-Distname epel8
https://pagure.io/releng/fedora-scm-requests/issue/44148

Comment 9 Gwyn Ciesla 2022-05-03 15:17:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Parse-Distname

Comment 10 Fedora Update System 2022-05-03 16:47:46 UTC
FEDORA-EPEL-2022-72f5f51db3 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-72f5f51db3

Comment 11 Fedora Update System 2022-05-03 16:47:47 UTC
FEDORA-2022-8debd65f1c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8debd65f1c

Comment 12 Fedora Update System 2022-05-03 16:47:47 UTC
FEDORA-2022-419c129c95 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-419c129c95

Comment 13 Fedora Update System 2022-05-04 12:41:59 UTC
FEDORA-2022-8debd65f1c has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8debd65f1c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8debd65f1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-05-04 14:10:47 UTC
FEDORA-2022-133941f2cb has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-133941f2cb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-133941f2cb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-05-04 14:21:54 UTC
FEDORA-EPEL-2022-8cdac2641e has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-8cdac2641e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-05-04 14:40:28 UTC
FEDORA-2022-419c129c95 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-419c129c95 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-419c129c95

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-05-04 15:03:30 UTC
FEDORA-EPEL-2022-72f5f51db3 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-72f5f51db3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-05-12 01:12:31 UTC
FEDORA-2022-8debd65f1c has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-05-12 01:20:14 UTC
FEDORA-2022-133941f2cb has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-05-12 01:46:11 UTC
FEDORA-EPEL-2022-8cdac2641e has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-05-12 01:46:57 UTC
FEDORA-2022-419c129c95 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2022-05-12 03:35:23 UTC
FEDORA-EPEL-2022-72f5f51db3 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.