Bug 2074384

Summary: SAP HANA template - template should be moved to https://github.com/RHsyseng/cnv-supplemental-templates
Product: Container Native Virtualization (CNV) Reporter: Dominik Holler <dholler>
Component: SSPAssignee: Dominik Holler <dholler>
Status: CLOSED ERRATA QA Contact: Geetika Kapoor <gkapoor>
Severity: low Docs Contact:
Priority: low    
Version: 4.10.0CC: cnv-qe-bugs, gouyang, ksimon, mtessun, nkoenig
Target Milestone: ---   
Target Release: 4.10.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-ssp-operator-container-v4.10.1-6 Doc Type: Enhancement
Doc Text:
The VM template for SAP HANA VMs is not installed out of the box anymore, to highlight that the template is neither supported nor certified. The template has to be explicitly installed according to the instructions from https://github.com/RHsyseng/cnv-supplemental-templates/tree/main/templates/saphana.
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-14 17:42:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dominik Holler 2022-04-12 06:45:14 UTC
Description of problem: Currently, the SAP HANA template is located in https://github.com/kubevirt/common-templates/ , which might be misleading and create the wrong impression that it is fully supported.


Version-Release number of selected component (if applicable):
CNV 4.10.0

How reproducible:
100%

Steps to Reproduce:
1. Install OpenShift Virtualization Operator
2. Create an Hyperconvered Instance
3.

Actual results:
The SAP HANA template is deployed.

Expected results:
The SAP HANA template is not deployed.

Comment 1 Dominik Holler 2022-04-12 07:18:20 UTC
QE verification should cover the removal of the template on upgrade from 4.10.0 .

Comment 2 Geetika Kapoor 2022-05-02 11:42:11 UTC
Test Setup Details:
-------------------

We have an upgraded cluster: 2.5.8->2.6.8->2.6.9->4.8.3->4.9.0->4.9.1->4.9.2->4.10.0->4.10.1

$ oc get csv -n openshift-cnv
NAME                                       DISPLAY                    VERSION   REPLACES                                   PHASE
kubevirt-hyperconverged-operator.v4.10.1   OpenShift Virtualization   4.10.1    kubevirt-hyperconverged-operator.v4.10.0   Succeeded
$ oc get nodes
NAME                               STATUS   ROLES    AGE     VERSION
c01-dbn-258-b2m7w-master-0         Ready    master   2d21h   v1.23.5+70fb84c
c01-dbn-258-b2m7w-master-1         Ready    master   2d21h   v1.23.5+70fb84c
c01-dbn-258-b2m7w-master-2         Ready    master   2d21h   v1.23.5+70fb84c
c01-dbn-258-b2m7w-worker-0-f8h5g   Ready    worker   2d21h   v1.23.5+70fb84c
c01-dbn-258-b2m7w-worker-0-f8kb5   Ready    worker   2d21h   v1.23.5+70fb84c
c01-dbn-258-b2m7w-worker-0-n8c4d   Ready    worker   2d21h   v1.23.5+70fb84c



Test Environment:
-----------------

On this cluster, We still see SAP template.

$ oc get templates -A | grep -i sap
openshift           rhel8-saphana-tiny                                  Template for Red Hat Enterprise Linux 8.4 for SAP HANA workloads. Please cons...   13 (5 blank)      1

Comment 6 Dominik Holler 2022-05-04 08:57:17 UTC
Even the bug might be fixed already in 4.10.1, postponing it to 4.10.2, to have more time to get the verification from qe.

Comment 8 Geetika Kapoor 2022-06-01 14:42:53 UTC
Setup: cnv version >= 4.10.1

Run the tests on SAP worker node.


Test Cases:

1. Existing tests pick template from url="https://raw.githubusercontent.com/RHsyseng/cnv-supplemental-templates/main/templates/saphana/rhel8.saphana.yaml"
2. Tests works as expected.
3. UI still show deprecated templates and doesn't see label template.kubevirt.io/deprecated: 'true'. Bug is raised for that failure. 
https://bugzilla.redhat.com/show_bug.cgi?id=2092230

Comment 14 errata-xmlrpc 2022-06-14 17:42:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.10.2 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5026