Bug 2074405

Summary:	Review Request: golang-github-timtadh-data-structures - Extra Go data structures
Product:	[Fedora] Fedora	Reporter:	Julien Rische <jrische>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, package-review, steve.traylen
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-25 16:39:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2074458

Description Julien Rische 2022-04-12 07:52:36 UTC

Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04176987-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.5.3-1.fc37.src.rpm

Description:
Extra Go data structures.

Fedora Account System Username: jrische

Source RPM repo: https://pagure.io/rpm-golang-github-timtadh-data-structures

Copr: https://copr.fedorainfracloud.org/coprs/jrische/golang-github-timtadh-data-structures/

The source RPM includes 3 patches in order to:
- Fix obsolete Go syntax in tests
- Fix bug on 32 bits architectures

Comment 1 Steve Traylen 2022-04-14 13:43:06 UTC

The three patches , they look like they should go upstream, can you submit and provide links:

https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/#_all_patches_should_have_an_upstream_bug_link_or_comment

Comment 2 Steve Traylen 2022-04-14 13:47:18 UTC

rpmlint results:

golang-github-timtadh-data-structures.spec: W: no-%build-section
golang-github-timtadh-data-structures.spec:20: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 20)
golang-github-timtadh-data-structures-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/timtadh/data-structures/.goipath
=================================== 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.6 s ===================================
[fedora@fed34 result]$

In the past I've just done

%build
# nothing to build 

but happy to go with what the go pages suggest.

Comment 3 Julien Rische 2022-04-29 15:52:18 UTC

I removed tabs from the spec file.

I opened a PR for each patch (link in patch files[1]).

According to the Go packaging documentation[2], the %build section can be ignored in devel-only packages.

Here[3] is the latest build.

[1] https://pagure.io/rpm-golang-github-timtadh-data-structures/tree/rawhide
[2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_packaging_a_binary_the_build_section
[3] https://copr.fedorainfracloud.org/coprs/jrische/golang-github-timtadh-data-structures/build/4346248/

Comment 4 Julien Rische 2022-06-24 16:28:47 UTC

Re-generate spec file using go2rpm:

Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04561930-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.5.3-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04561930-golang-github-timtadh-data-structures/fedora-review/review.txt

Comment 5 Julien Rische 2022-07-18 09:17:28 UTC

All the patches were merged upstream. I updated the spec file:

Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04640378-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.6.2-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04640378-golang-github-timtadh-data-structures/fedora-review/review.txt

Comment 6 Julien Rische 2022-08-25 16:39:27 UTC

This package was an indirect dependency of yq, but it not longer is.