Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04176987-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.5.3-1.fc37.src.rpm Description: Extra Go data structures. Fedora Account System Username: jrische Source RPM repo: https://pagure.io/rpm-golang-github-timtadh-data-structures Copr: https://copr.fedorainfracloud.org/coprs/jrische/golang-github-timtadh-data-structures/ The source RPM includes 3 patches in order to: - Fix obsolete Go syntax in tests - Fix bug on 32 bits architectures
The three patches , they look like they should go upstream, can you submit and provide links: https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/#_all_patches_should_have_an_upstream_bug_link_or_comment
rpmlint results: golang-github-timtadh-data-structures.spec: W: no-%build-section golang-github-timtadh-data-structures.spec:20: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 20) golang-github-timtadh-data-structures-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/timtadh/data-structures/.goipath =================================== 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.6 s =================================== [fedora@fed34 result]$ In the past I've just done %build # nothing to build but happy to go with what the go pages suggest.
I removed tabs from the spec file. I opened a PR for each patch (link in patch files[1]). According to the Go packaging documentation[2], the %build section can be ignored in devel-only packages. Here[3] is the latest build. [1] https://pagure.io/rpm-golang-github-timtadh-data-structures/tree/rawhide [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_packaging_a_binary_the_build_section [3] https://copr.fedorainfracloud.org/coprs/jrische/golang-github-timtadh-data-structures/build/4346248/
Re-generate spec file using go2rpm: Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04561930-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.5.3-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04561930-golang-github-timtadh-data-structures/fedora-review/review.txt
All the patches were merged upstream. I updated the spec file: Spec URL: https://pagure.io/rpm-golang-github-timtadh-data-structures/raw/rawhide/f/golang-github-timtadh-data-structures.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04640378-golang-github-timtadh-data-structures/golang-github-timtadh-data-structures-0.6.2-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-data-structures/fedora-rawhide-x86_64/04640378-golang-github-timtadh-data-structures/fedora-review/review.txt
This package was an indirect dependency of yq, but it not longer is.