Bug 2074458

Summary:	Review Request: golang-github-timtadh-lexmachine - Lex machinary for Go
Product:	[Fedora] Fedora	Reporter:	Julien Rische <jrische>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-25 16:40:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2074405
Bug Blocks:

Description Julien Rische 2022-04-12 09:17:47 UTC

Spec URL: https://pagure.io/rpm-golang-github-timtadh-lexmachine
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04176911-golang-github-timtadh-lexmachine/golang-github-timtadh-lexmachine-0.2.2-1.fc37.src.rpm

Description:
A full lexical analysis framework for the Go programming language.

Fedora Account System Username: jrische

Source RPM repo: https://pagure.io/rpm-golang-github-timtadh-lexmachine

Copr: https://copr.fedorainfracloud.org/coprs/jrische/golang-github-timtadh-lexmachine/

Comment 1 Maxwell G 2022-05-21 23:26:22 UTC

Your SPEC URL is wrong. I'm fixing it for you:

Spec URL: https://pagure.io/rpm-golang-github-timtadh-lexmachine/raw/rawhide/f/golang-github-timtadh-lexmachine.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04176911-golang-github-timtadh-lexmachine/golang-github-timtadh-lexmachine-0.2.2-1.fc37.src.rpm

You should also regenerate the specfile using go2rpm.

Comment 2 Julien Rische 2022-06-24 16:31:01 UTC

Re-generate spec file using go2rpm:

Spec URL: https://pagure.io/rpm-golang-github-timtadh-lexmachine/raw/rawhide/f/golang-github-timtadh-lexmachine.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04562057-golang-github-timtadh-lexmachine/golang-github-timtadh-lexmachine-0.2.2-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04562057-golang-github-timtadh-lexmachine/fedora-review/review.txt

Comment 3 Julien Rische 2022-06-29 10:32:40 UTC

I removed the glob for the executable file in the %files section.

Spec URL: https://pagure.io/rpm-golang-github-timtadh-lexmachine/raw/rawhide/f/golang-github-timtadh-lexmachine.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04583617-golang-github-timtadh-lexmachine/golang-github-timtadh-lexmachine-0.2.2-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-timtadh-lexmachine/fedora-rawhide-x86_64/04583617-golang-github-timtadh-lexmachine/fedora-review/review.txt

Comment 4 Julien Rische 2022-08-25 16:40:42 UTC

This package was a dependency of yq, but it not longer is.