Bug 2074467
| Summary: | Review Request: yq - Portable command-line YAML, JSON and XML processor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Rische <jrische> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dustymabe, lukas, maxwell, mikel, package-review, tpopela |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | NotReady | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-11-26 00:45:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1270054, 1946151, 2031922, 2074406, 2074412, 2074438, 2074463, 2107472 | ||
| Bug Blocks: | |||
|
Description
Julien Rische
2022-04-12 09:38:18 UTC
Re-generate spec file using go2rpm: Spec URL: https://pagure.io/rpm-yq/raw/rawhide/f/yq.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide-x86_64/04562127-yq/yq-4.25.3-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide-x86_64/04562127-yq/fedora-review/review.txt I removed the glob for the executable file in %files. Spec URL: https://pagure.io/rpm-yq/raw/rawhide/f/yq.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide-x86_64/04585023-yq/yq-4.25.3-1.fc37.src.rpm Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/yq/fedora-rawhide-x86_64/04585023-yq/fedora-review/review.txt https://github.com/mikefarah/yq/releases/tag/v4.26.1 has been released. There have been some dependency changes upstream, so make sure to open new review requests for those. I would close the review requests for the dependencies that have been removed, as we generally try to avoid packaging libraries that aren't actually needed for anything, but I won't object if you feel strongly about keeping them. The current version is v4.27.2. There is no dependency on github.com/timtadh/lexmachine, github.com/timtadh/data-structures, and github.com/timtadh/getopt any more. There are 2 new dependencies that are already packaged: github.com/alecthomas/repr[1] and github.com/goccy/go-json[2]. Lexmachine was replaced by github.com/alecthomas/participle, which is not packaged. I am working on it, but the fact the version that is currently required by yq (2.0.0-beta.4) is containing a dash character is causing a conflict with Fedora's version format. Version 2.0.0 is not released yet. [1] https://src.fedoraproject.org/rpms/golang-github-alecthomas-repr [2] https://src.fedoraproject.org/rpms/golang-github-goccy-json > Lexmachine was replaced by github.com/alecthomas/participle, which is not
> packaged. I am working on it, but the fact the version that is currently
> required by yq (2.0.0-beta.4) is containing a dash character is causing a
> conflict with Fedora's version format. Version 2.0.0 is not released yet.
Try adding `%global tag %(tr '~' '-' <<< %{version}) (with the proper indentation) right below Version and set Version to `2.0.0~beta.4`.
Are you interested in updating the package and proceeding with this review? This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. I am still working on this package. There have been more dependencies changes. I will be opening other packages review requests for these. > %global goipath github.com/mikefarah/yq Should be github.com/mikefarah/yq/v4 It would be interesting to add shell completions: https://mikefarah.gitbook.io/yq/commands/shell-completion Check doctl's spec as example. Similar with man pages: https://github.com/mikefarah/yq/blob/master/debian/rules#L51 |