- I would recommend including a comment with a link to the upstream PR above the `Patch0:` entry. I see that it's already included in the patch itself.
- You should regenerate the specfile using `go2rpm github.com/goccy/go-yaml`. Currently, you are missing a `%godocs` definition and a check bcond.

I did not realize that you still need a sponsor. As per the Package Maintainers docs, you should have your review request block FE-NEEDSPONSOR[1] and include some information to help potential sponsors. Any packager can review your package, but an actual sponsor (I am not one) will need to sponsor you into the packagers group.

[1]: https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/#requesting_sponsorship

@jrische, are you still interested in proceeding with this review?

Yes I am. I used go2rpm to regenerate the spec file:

Spec URL: https://pagure.io/rpm-golang-github-goccy-yaml/blob/rawhide/f/golang-github-goccy-yaml.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-goccy-yaml/fedora-rawhide-x86_64/04561712-golang-github-goccy-yaml/golang-github-goccy-yaml-1.9.5-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-goccy-yaml/fedora-rawhide-x86_64/04561712-golang-github-goccy-yaml/fedora-review/review.txt

Hi Julien,

Thanks for updating your spec! For the `Spec URL` field, please use the "raw" text only link on Pagure instead of the "blob" html one. The fedora-review tool will not be able to process it otherwise. I should be able to use the fedora-review output from COPR and not run it myself, but you should still use the proper URL :).

Spec URL: https://pagure.io/rpm-golang-github-goccy-yaml/blob/rawhide/f/golang-github-goccy-yaml.spec

> %{_bindir}/*
You should replace this with the actual filename instead of a glob, as per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. This is something that needs to be fixed in go2rpm.

As for your sponsorship, you should send an introduction email to the devel list if you haven't already[1]. Please make sure that all of your review requests block  	FE-NEEDSPONSOR.

[1]: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/#introduce_yourself

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint erros
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [!] The package complies with the Packaging Guidelines.
- [!] Package does not use globs in shared directories

Hi Maxwell,
I modified the spec to name the executable file explicitly in the %files section. Regarding the self-introduction email, I've already sent it in February[1].

Spec URL: https://pagure.io/rpm-golang-github-goccy-yaml/raw/rawhide/f/golang-github-goccy-yaml.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-goccy-yaml/fedora-rawhide-x86_64/04583544-golang-github-goccy-yaml/golang-github-goccy-yaml-1.9.5-1.fc37.src.rpm

Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-goccy-yaml/fedora-rawhide-x86_64/04583544-golang-github-goccy-yaml/fedora-review/review.txt

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/RKNQVLGTUXJJ364NFOMMJE3VLCJDS3X2/

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-goccy-yaml

FEDORA-2022-7212b6aa9b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7212b6aa9b

FEDORA-2022-7212b6aa9b has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-2f6233e732 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2f6233e732

FEDORA-2022-64c8d0b5d7 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-64c8d0b5d7

FEDORA-2022-2f6233e732 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-2f6233e732 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2f6233e732

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-64c8d0b5d7 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-64c8d0b5d7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-64c8d0b5d7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3969b64d4b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3969b64d4b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-64c8d0b5d7 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.