Bug 2074651
| Summary: | Review Request: python-sphinx-autobuild - Autobuild a Sphinx directory when a change is detected | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | dominik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-07 04:12:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2074652 | ||
|
Description
Jerry James
2022-04-12 17:54:40 UTC
Taking review. Licensing is fine (MIT). Source matches upstream: $ sha512sum sphinx-autobuild-2021.3.14.tar.gz sphinx-autobuild-2021.3.14.tar.gz.orig 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz.orig Builds fine in mock. Internal testsuite passes. Spec is clean and legible. rpmlint clean. Requires and provides are sane: $ rpm -qpR python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm /usr/bin/python3 python(abi) = 3.10 python3.10dist(colorama) python3.10dist(livereload) python3.10dist(sphinx) $ rpm -qp --provides python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm python-sphinx-autobuild = 2021.3.14-1.fc37 python3-sphinx-autobuild = 2021.3.14-1.fc37 python3.10-sphinx-autobuild = 2021.3.14-1.fc37 python3.10dist(sphinx-autobuild) = 2021.3.14 python3dist(sphinx-autobuild) = 2021.3.14 jquery 3.5.1 and underscore 1.13.1 are bundled in the doc subpackage, you might want to declare that in Provides: bundled(). This is of course coming from sphinx and was discussed as recently as February: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZVILBEZB6MIZXP3JVQSVNCP7Q6MK4G7D/ . You can fix this while importing as the package is good otherwise. Approved. (In reply to Dominik 'Rathann' Mierzejewski from comment #2) > jquery 3.5.1 and underscore 1.13.1 are bundled in the doc subpackage, you > might want to declare that in Provides: bundled(). I will fix that before importing. Thank you for the review! FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532 FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9161e75532` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |