Bug 2074652 - Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow
Summary: Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme dev...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2074647 2074651
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-12 17:54 UTC by Jerry James
Modified: 2022-05-07 04:12 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-07 04:12:50 UTC
Type: ---
Embargoed:
dominik: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2022-04-12 17:54:46 UTC
Spec URL: https://jjames.fedorapeople.org/python-sphinx-theme-builder/python-sphinx-theme-builder.spec
SRPM URL: https://jjames.fedorapeople.org/python-sphinx-theme-builder/python-sphinx-theme-builder-0.2.0-0.1.a14.fc37.src.rpm
Fedora Account System Username: jjames
Description: A tool for authoring Sphinx themes with a simple (opinionated) workflow.

Comment 1 Dominik 'Rathann' Mierzejewski 2022-04-12 23:02:38 UTC
Taking review.

Comment 2 Dominik 'Rathann' Mierzejewski 2022-04-13 11:58:15 UTC
Licensing:
Most of the code is under MIT license (no headers in files though), but src/sphinx_theme_builder/_internal/passthrough.py is under BSD 3-Clause License, so please mention this in a comment next to the License: field and update it.

Source matches upstream:
$ sha512sum sphinx-theme-builder-0.2.0a14.tar.gz sphinx-theme-builder-0.2.0a14.tar.gz.orig 
15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9  sphinx-theme-builder-0.2.0a14.tar.gz
15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9  sphinx-theme-builder-0.2.0a14.tar.gz.orig

Builds fine in mock.
Internal testsuite passes.
Spec is clean and legible.
rpmlint clean.

Requires and provides are sane:
$ rpm -qpR python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm ; echo ; rpm -qp --provides python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm 
/usr/bin/python3
python(abi) = 3.10
python3.10dist(nodeenv)
python3.10dist(packaging)
python3.10dist(pep621)
python3.10dist(rich)
python3.10dist(setuptools)
python3.10dist(tomli)

python-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3.10-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3.10dist(sphinx-theme-builder) = 0.2~a14
python3dist(sphinx-theme-builder) = 0.2~a14

You can fix the minor licensing issue when importing, package approved.

Comment 3 Jerry James 2022-04-14 03:19:20 UTC
Thank you for the review!  I will fix the license issue as you described.

Comment 4 Gwyn Ciesla 2022-04-14 13:31:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-theme-builder

Comment 5 Fedora Update System 2022-04-20 20:59:40 UTC
FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

Comment 6 Fedora Update System 2022-04-20 23:05:33 UTC
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9161e75532`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-05-07 04:12:50 UTC
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.