Bug 2075218

Summary:	Review Request: rust-userfaultfd - Rust bindings for the Linux userfaultfd functionality
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-15 16:16:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2075217
Bug Blocks:	2075222

Description Fabio Valentini 2022-04-13 20:21:28 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-userfaultfd.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-userfaultfd-0.4.2-1.fc36.src.rpm

Description:
Rust bindings for the Linux userfaultfd functionality.

Fedora Account System Username: decathorpe

Comment 1 Michel Lind 2022-04-14 18:35:07 UTC

Reviewing using COPR build:
copr-cli download-build -r fedora-rawhide-x86_64 4220176

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite passes
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 2 Michel Lind 2022-04-14 18:39:16 UTC

s/MIT/MIT or Apache

Comment 3 Fabio Valentini 2022-04-14 18:51:51 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/43696
https://pagure.io/releng/fedora-scm-requests/issue/43697
https://pagure.io/releng/fedora-scm-requests/issue/43698
https://pagure.io/releng/fedora-scm-requests/issue/43699

Comment 4 Gwyn Ciesla 2022-04-14 19:01:57 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-userfaultfd

Comment 5 Fabio Valentini 2022-04-15 16:16:11 UTC

Built and submitted for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-31e5d41c38