Bug 2075217 - Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux
Summary: Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd fun...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2075218
TreeView+ depends on / blocked
 
Reported: 2022-04-13 20:20 UTC by Fabio Valentini
Modified: 2022-04-15 16:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-15 16:16:05 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2022-04-13 20:20:28 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-userfaultfd-sys.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-userfaultfd-sys-0.4.1-1.fc36.src.rpm

Description:
Low-level bindings for userfaultfd functionality on Linux.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=85630687

Comment 1 Michel Lind 2022-04-14 17:26:25 UTC
Taking this review

Comment 2 Michel Lind 2022-04-14 18:29:52 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite passes
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Michel Lind 2022-04-14 18:39:40 UTC
s/MIT/MIT OR Apache

Comment 5 Gwyn Ciesla 2022-04-14 19:00:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-userfaultfd-sys

Comment 6 Fabio Valentini 2022-04-15 16:16:05 UTC
Built and submitted for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-31e5d41c38


Note You need to log in before you can comment on or make changes to this bug.