Bug 207607
Summary: | Review Request: telepathy-butterfly - MSN connection manager for Telepathy | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
Component: | Package Review | Assignee: | Sander Hoentjen <sander> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-02 16:09:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 207173 | ||
Bug Blocks: | 163779, 205343 |
Description
Brian Pepple
2006-09-21 20:26:43 UTC
can you switch telepathy-filesystem to noarch? Yeah, I can make the filesystem a noarch package. ok, once you do that the filesystem package is APPROVED I will give a review on butterfly soon telepathy-butterfly: Good: - rpmlint checks return with no output - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on mock devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED Thanks for the review. |