Bug 207665

Summary: Redundant semicolon breaks header files
Product: [Fedora] Fedora Reporter: Hans Ulrich Niedermann <rhbugs>
Component: SDL_gfxAssignee: Matthias Saou <matthias>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 5CC: extras-qa
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.0.13-6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-22 13:30:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hans Ulrich Niedermann 2006-09-22 12:58:20 UTC 
Description of problem:

  The C++ conditionals should look like this:
     extern "C" { ... }
  but in fact look like this
     extern "C" { ... };

  Affected files:
    #include <SDL/SDL_imageFilter.h>
    #include <SDL/SDL_gfxPrimitives.h>

  Error message:
    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Version-Release number of selected component (if applicable):

  SDL_gfx-devel-2.0.13-4.fc5

How reproducible:

  Every time.

Steps to Reproduce:

  g++ -ansi -pedantic -o testprog testprog.cxx
  
Actual results:

    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Expected results:

   No error.

Additional info:

  There aren't many header files with the semicolon any more:

  # grep -r -A2 __cplusplus /usr/include | grep -- '-};$'
  /usr/include/crack.h-};
  /usr/include/xmms/configfile.h-};
  /usr/include/xmms/titlestring.h-};
  /usr/include/xmms/xmmsctrl.h-};
  /usr/include/xmms/dirbrowser.h-};
  /usr/include/magic.h-};
Comment 1 Matthias Saou 2006-09-22 13:30:42 UTC 
Thanks for the report. I've added a quick patch to fix these and new packages
for FC4, FC5 and FC6 are on their way.