Bug 207665 - Redundant semicolon breaks header files
Redundant semicolon breaks header files
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: SDL_gfx (Show other bugs)
5
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Saou
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-22 08:58 EDT by Hans Ulrich Niedermann
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version: 2.0.13-6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-09-22 09:30:42 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Hans Ulrich Niedermann 2006-09-22 08:58:20 EDT
Description of problem:

  The C++ conditionals should look like this:
     extern "C" { ... }
  but in fact look like this
     extern "C" { ... };

  Affected files:
    #include <SDL/SDL_imageFilter.h>
    #include <SDL/SDL_gfxPrimitives.h>

  Error message:
    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Version-Release number of selected component (if applicable):

  SDL_gfx-devel-2.0.13-4.fc5

How reproducible:

  Every time.

Steps to Reproduce:

  g++ -ansi -pedantic -o testprog testprog.cxx
  
Actual results:

    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Expected results:

   No error.

Additional info:

  There aren't many header files with the semicolon any more:

  # grep -r -A2 __cplusplus /usr/include | grep -- '-};$'
  /usr/include/crack.h-};
  /usr/include/xmms/configfile.h-};
  /usr/include/xmms/titlestring.h-};
  /usr/include/xmms/xmmsctrl.h-};
  /usr/include/xmms/dirbrowser.h-};
  /usr/include/magic.h-};
Comment 1 Matthias Saou 2006-09-22 09:30:42 EDT
Thanks for the report. I've added a quick patch to fix these and new packages
for FC4, FC5 and FC6 are on their way.

Note You need to log in before you can comment on or make changes to this bug.