Bug 207665 - Redundant semicolon breaks header files
Summary: Redundant semicolon breaks header files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: SDL_gfx
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Saou
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-09-22 12:58 UTC by Hans Ulrich Niedermann
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: 2.0.13-6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-22 13:30:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Hans Ulrich Niedermann 2006-09-22 12:58:20 UTC
Description of problem:

  The C++ conditionals should look like this:
     extern "C" { ... }
  but in fact look like this
     extern "C" { ... };

  Affected files:
    #include <SDL/SDL_imageFilter.h>
    #include <SDL/SDL_gfxPrimitives.h>

  Error message:
    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Version-Release number of selected component (if applicable):

  SDL_gfx-devel-2.0.13-4.fc5

How reproducible:

  Every time.

Steps to Reproduce:

  g++ -ansi -pedantic -o testprog testprog.cxx
  
Actual results:

    /usr/include/SDL/SDL_imageFilter.h:189: error: extra ';'
    /usr/include/SDL/SDL_gfxPrimitives.h:190: error: extra ';'

Expected results:

   No error.

Additional info:

  There aren't many header files with the semicolon any more:

  # grep -r -A2 __cplusplus /usr/include | grep -- '-};$'
  /usr/include/crack.h-};
  /usr/include/xmms/configfile.h-};
  /usr/include/xmms/titlestring.h-};
  /usr/include/xmms/xmmsctrl.h-};
  /usr/include/xmms/dirbrowser.h-};
  /usr/include/magic.h-};

Comment 1 Matthias Saou 2006-09-22 13:30:42 UTC
Thanks for the report. I've added a quick patch to fix these and new packages
for FC4, FC5 and FC6 are on their way.


Note You need to log in before you can comment on or make changes to this bug.