Bug 2078013

Summary: drop multipathd.socket workaround
Product: OpenShift Container Platform Reporter: Micah Abbott <miabbott>
Component: RHCOSAssignee: Micah Abbott <miabbott>
Status: CLOSED ERRATA QA Contact: HuijingHei <hhei>
Severity: low Docs Contact:
Priority: medium    
Version: 4.11CC: dornelas, jligon, miabbott, mrussell, nstielau, qzhang, ybettan
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2078016 (view as bug list) Environment:
Last Closed: 2022-08-10 11:08:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2078016    

Description Micah Abbott 2022-04-22 20:08:00 UTC
We are carrying a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=2008101 in RHCOS 4.11 and 4.10

The fix for the BZ was included in RHEL 8.6 through RHEL 8.4.z EUS, so we are in a position to drop the workaround.

Comment 1 Yoni Bettan 2022-04-25 12:22:08 UTC
Should the priority changed to "urgent"? It is basically a blocker.
@miabbott

Comment 2 Micah Abbott 2022-04-26 19:42:00 UTC
I disagree this is a blocker.  Can you elaborate why you think that is the case?

Comment 3 Yoni Bettan 2022-04-27 17:00:41 UTC
Just because it was set by "RHCOS Bug Bot" to block 2078016.
But I see the the supposedly blocked BZ is already ON_QA so maybe this is not the case.
Sorry for the noise.

Comment 4 Micah Abbott 2022-04-28 18:28:34 UTC
Need to bump the f-c-c submodule on openshift/os next

Comment 5 Micah Abbott 2022-07-07 13:55:43 UTC
The fedora-coreos-config bump required landed here https://github.com/openshift/os/commit/5a56561b72df5008f4216ca71a970ee6de494a46

This should be part of RHCOS 4.11

Comment 7 HuijingHei 2022-07-08 03:14:35 UTC
Verify passed on 4.11.0-0.nightly-2022-07-06-145812, the workaround has been removed and multipathd.socket includes the start condition.

[coreos-assembler]$ oc get clusterversion
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.11.0-0.nightly-2022-07-06-145812   True        False         5m10s   Cluster version is 4.11.0-0.nightly-2022-07-06-145812
[coreos-assembler]$ oc get nodes
NAME                           STATUS   ROLES    AGE   VERSION
ip-10-0-145-69.ec2.internal    Ready    master   19m   v1.24.0+2dd8bb1
ip-10-0-153-242.ec2.internal   Ready    worker   13m   v1.24.0+2dd8bb1
ip-10-0-153-58.ec2.internal    Ready    worker   13m   v1.24.0+2dd8bb1
ip-10-0-164-116.ec2.internal   Ready    master   19m   v1.24.0+2dd8bb1
ip-10-0-226-227.ec2.internal   Ready    master   19m   v1.24.0+2dd8bb1
ip-10-0-252-22.ec2.internal    Ready    worker   10m   v1.24.0+2dd8bb1


$ oc debug node/ip-10-0-145-69.ec2.internal
sh-4.4# chroot /host
sh-4.4# rpm-ostree status
State: idle
Deployments:
* pivot://quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:04b54950ce296d73746f22b66ff6c5484c37be78cb34aaf352338359112fa241
              CustomOrigin: Managed by machine-config-operator
                   Version: 411.86.202207011902-0 (2022-07-01T19:05:18Z)

  0505ffc1c711903785f27570819e973f086f594a8daa3ec9dfe2a059586ac42f
                   Version: 411.86.202206301504-0 (2022-06-30T15:08:01Z)

sh-4.4# rpm -qa device-mapper-multipath
device-mapper-multipath-0.8.4-22.el8.x86_64

sh-4.4# ls -lR /usr/lib/systemd/system/multipathd.socket 
-rw-r--r--. 3 root root 304 Jan  1  1970 /usr/lib/systemd/system/multipathd.socket
sh-4.4# systemctl cat multipathd.socket
# /usr/lib/systemd/system/multipathd.socket
[Unit]
Description=multipathd control socket
DefaultDependencies=no
ConditionPathExists=/etc/multipath.conf
ConditionKernelCommandLine=!nompath
ConditionKernelCommandLine=!multipath=off
Before=sockets.target

[Socket]
ListenStream=@/org/kernel/linux/storage/multipathd

[Install]
WantedBy=sockets.target

Comment 9 errata-xmlrpc 2022-08-10 11:08:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069