Bug 2079394
| Summary: | Review Request: R-kernlab - Kernel-based machine learning lab | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ali Erdinc Koroglu <ali.erdinc.koroglu> |
| Component: | Package Review | Assignee: | Iñaki Ucar <i.ucar86> |
| Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i.ucar86, package-review |
| Target Milestone: | --- | Flags: | i.ucar86:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-28 11:42:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ali Erdinc Koroglu
2022-04-27 13:32:08 UTC
Comments:
- The license is GPLv2, not GPLv2+.
- Please, use the following for the source (see the R packaging guidelines):
Source: %{url}&version=%{packvers}-%{packrel}#/%{packname}_%{packvers}-%{packrel}.tar.gz
- "BuildRequires: gcc-c++" is a general requirement for C++ programs, but it is redundant in R packages. "BuildRequires: R-devel" is enough, so please remove the former.
- Please express the texlive dependency as follows:
BuildRequires: tex(a4wide.sty)
- "Require: R-core" is also redundant, please remove it.
- Please mark the following files as %doc:
%{rlibdir}/%{packname}/doc
%{rlibdir}/%{packname}/html
%{rlibdir}/%{packname}/CITATION
Hello Iñaki, I updated the package, thank you. SPEC URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04662600-R-kernlab/R-kernlab.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04662600-R-kernlab/R-kernlab-0.9.31-1.fc37.src.rpm LGTM. rpmlint output is clean, Requires are sane. Package APPROVED. |