Bug 2079394 - Review Request: R-kernlab - Kernel-based machine learning lab
Summary: Review Request: R-kernlab - Kernel-based machine learning lab
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Iñaki Ucar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-27 13:32 UTC by Ali Erdinc Koroglu
Modified: 2022-07-28 11:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-28 11:42:25 UTC
Type: Bug
Embargoed:
i.ucar86: fedora-review+


Attachments (Terms of Use)

Comment 1 Iñaki Ucar 2022-07-21 15:46:36 UTC
Comments:

- The license is GPLv2, not GPLv2+.

- Please, use the following for the source (see the R packaging guidelines):

Source:		%{url}&version=%{packvers}-%{packrel}#/%{packname}_%{packvers}-%{packrel}.tar.gz

- "BuildRequires: gcc-c++" is a general requirement for C++ programs, but it is redundant in R packages. "BuildRequires: R-devel" is enough, so please remove the former.

- Please express the texlive dependency as follows:

BuildRequires:	tex(a4wide.sty)

- "Require: R-core" is also redundant, please remove it.

- Please mark the following files as %doc:

%{rlibdir}/%{packname}/doc
%{rlibdir}/%{packname}/html
%{rlibdir}/%{packname}/CITATION

Comment 3 Iñaki Ucar 2022-07-22 15:38:48 UTC
LGTM. rpmlint output is clean, Requires are sane. Package APPROVED.

Comment 4 Ali Erdinc Koroglu 2022-07-28 11:42:25 UTC
https://src.fedoraproject.org/rpms/R-kernlab


Note You need to log in before you can comment on or make changes to this bug.