Bug 2081377

Summary:	Remove pf-c-code-block__pre when pf supports classnames for copytoclipboard component
Product:	OpenShift Container Platform	Reporter:	Joe Caiani <jcaiani>
Component:	Management Console	Assignee:	Yanping Zhang <yanpzhan>
Status:	CLOSED DEFERRED	QA Contact:	Yanping Zhang <yanpzhan>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.11	CC:	yanpzhan, yapei
Target Milestone:	---	Flags:	jcaiani: needinfo-
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-03-09 01:18:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joe Caiani 2022-05-03 14:36:08 UTC

Description of problem:
Remove pf-c-code-block__pre when pf supports passing classnames to the  copytoclipboard component
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 4 Yanping Zhang 2022-05-31 10:14:18 UTC

Checked on ocp 4.11 cluster with payload 4.11.0-0.nightly-2022-05-25-193227.
Go to one secret detail page, check the copy-to-clipboard function, could copy successfully.
Check the copied text element: <pre class="pf-c-code-block__pre co-copy-to-clipboard__text" data-test="copy-to-clipboard"><code class="pf-c-code-block__code">AKIAJQ56NS6LSXPMTPOQ</code></pre>
There is still "pf-c-code-block__pre" in "class" property. @Joe, is it correct? pls refer to screenshot.

Comment 7 Yanping Zhang 2022-06-17 00:52:55 UTC

Move back to ASSIGNED for dev to investigate the fix.

Comment 10 Joe Caiani 2022-08-22 21:20:12 UTC

@yanpzhan this is ok, as long as we're not using the code-block__pre in the classNames prop directly in the <CodeBlockCode/> component in the copy-to-clipboard.tsx file

Comment 11 Shiftzilla 2023-03-09 01:18:27 UTC

OpenShift has moved to Jira for its defect tracking! This bug can now be found in the OCPBUGS project in Jira.

https://issues.redhat.com/browse/OCPBUGS-9248

Comment 12 Red Hat Bugzilla 2023-09-18 04:36:31 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days