Bug 2081377 - Remove pf-c-code-block__pre when pf supports classnames for copytoclipboard component
Summary: Remove pf-c-code-block__pre when pf supports classnames for copytoclipboard c...
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.11
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: ---
Assignee: Yanping Zhang
QA Contact: Yanping Zhang
Depends On:
TreeView+ depends on / blocked
Reported: 2022-05-03 14:36 UTC by Joe Caiani
Modified: 2023-09-18 04:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-03-09 01:18:27 UTC
Target Upstream Version:
jcaiani: needinfo-

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift console pull 11431 0 None open Bug 2081377: Remove pf-c-code-block__pre since pf updated allows classnames 2022-05-03 15:52:13 UTC

Description Joe Caiani 2022-05-03 14:36:08 UTC
Description of problem:
Remove pf-c-code-block__pre when pf supports passing classnames to the  copytoclipboard component
Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

Comment 4 Yanping Zhang 2022-05-31 10:14:18 UTC
Checked on ocp 4.11 cluster with payload 4.11.0-0.nightly-2022-05-25-193227.
Go to one secret detail page, check the copy-to-clipboard function, could copy successfully.
Check the copied text element: <pre class="pf-c-code-block__pre co-copy-to-clipboard__text" data-test="copy-to-clipboard"><code class="pf-c-code-block__code">AKIAJQ56NS6LSXPMTPOQ</code></pre>
There is still "pf-c-code-block__pre" in "class" property. @Joe, is it correct? pls refer to screenshot.

Comment 7 Yanping Zhang 2022-06-17 00:52:55 UTC
Move back to ASSIGNED for dev to investigate the fix.

Comment 10 Joe Caiani 2022-08-22 21:20:12 UTC
@yanpzhan this is ok, as long as we're not using the code-block__pre in the classNames prop directly in the <CodeBlockCode/> component in the copy-to-clipboard.tsx file

Comment 11 Shiftzilla 2023-03-09 01:18:27 UTC
OpenShift has moved to Jira for its defect tracking! This bug can now be found in the OCPBUGS project in Jira.


Comment 12 Red Hat Bugzilla 2023-09-18 04:36:31 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days

Note You need to log in before you can comment on or make changes to this bug.