Bug 2083378

Summary:	storage role cannot set mount_options for volumes
Product:	Red Hat Enterprise Linux 8	Reporter:	Rich Megginson <rmeggins>
Component:	rhel-system-roles	Assignee:	Rich Megginson <rmeggins>
Status:	CLOSED ERRATA	QA Contact:	Zhang Yi <yizhan>
Severity:	unspecified	Docs Contact:	Michal Stubna <mstubna>
Priority:	unspecified
Version:	8.7	CC:	briasmit, djez, gfialova, nhosoi, pkettman, rhel-cs-system-management-subsystem-qe, spetrosi, yizhan
Target Milestone:	rc	Keywords:	Triaged, ZStream
Target Release:	8.7	Flags:	pkettman: needinfo+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	role:storage
Fixed In Version:	rhel-system-roles-1.18.0-1.el8	Doc Type:	Bug Fix
Doc Text:	.The `mount_options` parameter for volumes is now valid for a volume Previously, the parameter was accidentally removed from the list of valid parameters for a volume. Consequently, users were unable to set the `mount_options` parameter for volumes. With this bug fix, the `mount_options` parameter has been added back to the list of valid parameters and the code has been refactored to catch the errors. As a result, the `storage` RHEL system role can set the `mount_options` parameter for volumes.	Story Points:	---
Clone Of:	2083376
Clones:	2098227 (view as bug list)		Environment:
Last Closed:	2022-11-08 09:41:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2083376
Bug Blocks:	2098227

Description Rich Megginson 2022-05-09 20:17:37 UTC

+++ This bug was initially created as a clone of Bug #2083376 +++

Description of problem:

The "mount_options" parameter of "storage_volumes" does not work.  The parameter is documented here: https://github.com/linux-system-roles/storage#mount_options

I modified one of the existing tests to add

            mount_options: rw,noatime,defaults

For the controller, I'm using f35 with ansible-core 2.12, latest storage git repo.  For the managed host, I have tried rhel 8.5, rhel 8.6, and fedora 34.  They all give the same error:

'Unsupported parameters for (blivet) module: volumes.mount_options. Supported parameters include: volume_defaults, packages_only, disklabel_type, volumes, diskvolume_mkfs_option_map, pools, use_partitions, pool_defaults, safe_mode.'

This problem was introduced in this commit: https://github.com/linux-system-roles/storage/commit/c3b81cb8b44b587cbc9b0f274b08ebf483bbd0a8

Version-Release number of selected component (if applicable):

RHEL 8.6/RHEL 9.0

`mount_options` is supported in RHEL 8.5

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 10 errata-xmlrpc 2022-11-08 09:41:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:7568