Bug 2084132
| Summary: | Review Request: rust-lev_distance - Copy of Levenshtein distance implementation from Rust Compiler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carmelo Sarta <carmelo.sarta.main> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-14 12:10:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Carmelo Sarta
2022-05-11 13:47:36 UTC
One minor issue: "Copy of Levenshtein distance implementation from Rust Compiler" This isn't really gramatically correct English, is it? Maybe upstream would appreciate a PR to get this grammatically fixed in their Cargo.toml. Otherwise, looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lev_distance This package has been imported and built a long time ago: https://bodhi.fedoraproject.org/updates/FEDORA-2022-23fa852641 https://bodhi.fedoraproject.org/updates/FEDORA-2022-36f508397e https://bodhi.fedoraproject.org/updates/FEDORA-2022-cb7e9f67ee |