Bug 2084132 - Review Request: rust-lev_distance - Copy of Levenshtein distance implementation from Rust Compiler
Summary: Review Request: rust-lev_distance - Copy of Levenshtein distance implementati...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-11 13:47 UTC by Carmelo Sarta
Modified: 2022-10-14 12:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-14 12:10:54 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Carmelo Sarta 2022-05-11 13:47:36 UTC
Spec URL: https://raw.githubusercontent.com/Laiot/rust-lev_distance-srpm/master/rust-lev_distance.spec
SRPM URL: https://github.com/Laiot/rust-lev_distance-srpm/raw/master/rust-lev_distance-0.1.1-1.fc36.src.rpm
Description: Copy of Levenshtein distance implementation from Rust Compiler
Fedora Account System Username: laiot

Comment 1 Fabio Valentini 2022-05-12 16:08:25 UTC
One minor issue:

"Copy of Levenshtein distance implementation from Rust Compiler"
This isn't really gramatically correct English, is it? Maybe upstream would appreciate a PR to get this grammatically fixed in their Cargo.toml.

Otherwise, looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Gwyn Ciesla 2022-05-17 13:18:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lev_distance


Note You need to log in before you can comment on or make changes to this bug.