Bug 2084529
| Summary: | Review Request: python-flask-mod-auth-gssapi - A Flask extention to make use of the authentication provided by the mod_auth_gssapi extention of Apache's HTTPd. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Coady <scoady> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-06-28 08:43:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2087119 | ||
|
Description
Stephen Coady
2022-05-12 11:21:54 UTC
> %global debug_package %{nil} - This is redundant for noarch packages. > Requires: python3-flask > Requires: python3-gssapi - The python dependency generator should handle this. > rm -rf $RPM_BUILD_ROOT - This is no longer necessary. > %doc config/gssproxy.conf > %doc config/systemd-httpd-service.conf > %doc config/httpd.conf > %doc config/tmpfiles.conf - Why don't you shorten this to `%doc config` or better yet install the conf files to the proper location? - Is it possible to run the tests? If not, you should at least run `%py3_check_import flask_mod_auth_gssapi`. - You might want to consider porting this specfile to use the new pyproject-rpm-macros, but this isn't a hard requirement. @scoady, are you still interested in proceeding with this review? |