Bug 2084529 - Review Request: python-flask-mod-auth-gssapi - A Flask extention to make use of the authentication provided by the mod_auth_gssapi extention of Apache's HTTPd.
Summary: Review Request: python-flask-mod-auth-gssapi - A Flask extention to make use ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2087119
TreeView+ depends on / blocked
 
Reported: 2022-05-12 11:21 UTC by Stephen Coady
Modified: 2022-06-28 15:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-06-28 08:43:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Stephen Coady 2022-05-12 11:21:54 UTC
Spec URL: https://scoady.fedorapeople.org/python-flask-mod-auth-gssapi/python-flask-mod-auth-gssapi.spec
SRPM URL: https://scoady.fedorapeople.org/python-flask-mod-auth-gssapi/python-flask-mod-auth-gssapi-0.2.0-1.fc37.src.rpm
Description: A Flask extention to make use of the authentication provided by the mod_auth_gssapi extention of Apache's HTTPd.
Fedora Account System Username: scoady

Comment 1 Maxwell G 2022-05-19 04:04:02 UTC
> %global debug_package %{nil}

- This is redundant for noarch packages.

> Requires: python3-flask
> Requires: python3-gssapi

- The python dependency generator should handle this.

> rm -rf $RPM_BUILD_ROOT

- This is no longer necessary.

> %doc config/gssproxy.conf
> %doc config/systemd-httpd-service.conf
> %doc config/httpd.conf
> %doc config/tmpfiles.conf

- Why don't you shorten this to `%doc config` or better yet install the conf files to the proper location?

- Is it possible to run the tests? If not, you should at least run `%py3_check_import flask_mod_auth_gssapi`.

- You might want to consider porting this specfile to use the new pyproject-rpm-macros, but this isn't a hard requirement.

Comment 2 Maxwell G 2022-06-17 22:09:01 UTC
@scoady, are you still interested in proceeding with this review?


Note You need to log in before you can comment on or make changes to this bug.