Bug 2085468
Summary: | Review Request: golang-github-heistp-irtt - Isochronous Round-Trip Tester | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Toke Høiland-Jørgensen <thoiland> |
Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lkundrak, package-review |
Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-01-11 13:31:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Toke Høiland-Jørgensen
2022-05-13 12:39:24 UTC
* Package named correctly * Packaging the latest version * SPEC file clean and legible, consistent use of whitespace, macros * License tag seems correct * License good for Fedora * Builds in mock * rpmlint reasonably happy * Filelist sane * Requires/provides look good The package is APPROVED I've had trouble figuring out what license did the project developers intend to use. The only clue has been the "Re-licensed to GPLv2." sentence in CHANGES.md. I'm wondering if you could raise a ticket upstream about this? Perhaps they could mention the license in README.md or include a SPDX tag in the source files. Note this is not a review blocker. Thank you for the review! And yeah, the relicense is maybe not the clearest; the upstream commit[0] in question updates the project LICENSE file from the GPLv3 to GPLv2 text, but there's otherwise no indication of the license. I'll open an issue suggesting to add SPDX tags... [0] https://github.com/heistp/irtt/commit/c5ed230a672f5233f4a87b2a28dd6d5c86b6feba (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-heistp-irtt |