Spec URL: https://tohojo.fedorapeople.org/golang-github-heistp-irtt.spec SRPM URL: https://tohojo.fedorapeople.org/golang-github-heistp-irtt-0.9.1-1.fc37.src.rpm Description: IRTT is a UDP-based RTT test tool for high-precision RTT testing. Fedora Account System Username: tohojo This package is used by the Flent tool, so I'd like to add it as a dependency of the flent RPM.
* Package named correctly * Packaging the latest version * SPEC file clean and legible, consistent use of whitespace, macros * License tag seems correct * License good for Fedora * Builds in mock * rpmlint reasonably happy * Filelist sane * Requires/provides look good The package is APPROVED I've had trouble figuring out what license did the project developers intend to use. The only clue has been the "Re-licensed to GPLv2." sentence in CHANGES.md. I'm wondering if you could raise a ticket upstream about this? Perhaps they could mention the license in README.md or include a SPDX tag in the source files. Note this is not a review blocker.
Thank you for the review! And yeah, the relicense is maybe not the clearest; the upstream commit[0] in question updates the project LICENSE file from the GPLv3 to GPLv2 text, but there's otherwise no indication of the license. I'll open an issue suggesting to add SPDX tags... [0] https://github.com/heistp/irtt/commit/c5ed230a672f5233f4a87b2a28dd6d5c86b6feba
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-heistp-irtt